You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Sorin Suciu (JIRA)" <ji...@apache.org> on 2010/10/21 13:03:16 UTC

[jira] Created: (QPID-2910) Small fix for python timeout tests

Small fix for python timeout tests
----------------------------------

                 Key: QPID-2910
                 URL: https://issues.apache.org/jira/browse/QPID-2910
             Project: Qpid
          Issue Type: Bug
    Affects Versions: 0.7
         Environment: Python test suite
            Reporter: Sorin Suciu
            Assignee: Sorin Suciu
            Priority: Minor
             Fix For: 0.7


Currently the Connection class in qpid/messaging/endpoints initializes the transport with AMQP(S) first if an AMQP(S) url type is provided, but on the timeout tests the transport is proxied via the hangable so using an amqp:// URL breaks the timeout tests. This small patch changes the transport setup order, if a transport is passed in the options it gets set, only further we are checking for AMQP(S) url types and ultimately default to TCP. 


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2910) Small fix for python timeout tests

Posted by "Sorin Suciu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sorin Suciu updated QPID-2910:
------------------------------

    Attachment: qpid-2910.patch

> Small fix for python timeout tests
> ----------------------------------
>
>                 Key: QPID-2910
>                 URL: https://issues.apache.org/jira/browse/QPID-2910
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Python test suite
>            Reporter: Sorin Suciu
>            Assignee: Sorin Suciu
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: qpid-2910.patch
>
>
> Currently the Connection class in qpid/messaging/endpoints initializes the transport with AMQP(S) first if an AMQP(S) url type is provided, but on the timeout tests the transport is proxied via the hangable so using an amqp:// URL breaks the timeout tests. This small patch changes the transport setup order, if a transport is passed in the options it gets set, only further we are checking for AMQP(S) url types and ultimately default to TCP. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-2910) Small fix for python timeout tests

Posted by "Sorin Suciu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sorin Suciu reassigned QPID-2910:
---------------------------------

    Assignee: Andrew Kennedy  (was: Sorin Suciu)

Andrew, could you review and commit if all good please?

> Small fix for python timeout tests
> ----------------------------------
>
>                 Key: QPID-2910
>                 URL: https://issues.apache.org/jira/browse/QPID-2910
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Python test suite
>            Reporter: Sorin Suciu
>            Assignee: Andrew Kennedy
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: qpid-2910.patch
>
>
> Currently the Connection class in qpid/messaging/endpoints initializes the transport with AMQP(S) first if an AMQP(S) url type is provided, but on the timeout tests the transport is proxied via the hangable so using an amqp:// URL breaks the timeout tests. This small patch changes the transport setup order, if a transport is passed in the options it gets set, only further we are checking for AMQP(S) url types and ultimately default to TCP. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Resolved: (QPID-2910) Small fix for python timeout tests

Posted by "Andrew Kennedy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy resolved QPID-2910.
----------------------------------

    Resolution: Fixed

Reviewed and committed patch from Sorin S <ss...@gmail.com>

> Small fix for python timeout tests
> ----------------------------------
>
>                 Key: QPID-2910
>                 URL: https://issues.apache.org/jira/browse/QPID-2910
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Python test suite
>            Reporter: Sorin Suciu
>            Assignee: Andrew Kennedy
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: qpid-2910.patch
>
>
> Currently the Connection class in qpid/messaging/endpoints initializes the transport with AMQP(S) first if an AMQP(S) url type is provided, but on the timeout tests the transport is proxied via the hangable so using an amqp:// URL breaks the timeout tests. This small patch changes the transport setup order, if a transport is passed in the options it gets set, only further we are checking for AMQP(S) url types and ultimately default to TCP. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-2910) Small fix for python timeout tests

Posted by "Andrew Kennedy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Kennedy updated QPID-2910:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> Small fix for python timeout tests
> ----------------------------------
>
>                 Key: QPID-2910
>                 URL: https://issues.apache.org/jira/browse/QPID-2910
>             Project: Qpid
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Python test suite
>            Reporter: Sorin Suciu
>            Assignee: Andrew Kennedy
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: qpid-2910.patch
>
>
> Currently the Connection class in qpid/messaging/endpoints initializes the transport with AMQP(S) first if an AMQP(S) url type is provided, but on the timeout tests the transport is proxied via the hangable so using an amqp:// URL breaks the timeout tests. This small patch changes the transport setup order, if a transport is passed in the options it gets set, only further we are checking for AMQP(S) url types and ultimately default to TCP. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org