You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:33:06 UTC
[GitHub] [cordova-plugin-file-transfer] timbru31 opened a new pull request #270: fix!: remove deprecated platforms
timbru31 opened a new pull request #270:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/270
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
- Amazon Fire OS
- Blackberry 10
- Windows Phone
- Firefox OS
### Motivation and Context
Maintain only active platforms.
### Description
Removes deprecated platforms.
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file-transfer] erisu commented on a change in pull request #270: fix!: remove deprecated platforms
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #270:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/270#discussion_r477198900
##########
File path: tests/tests.js
##########
@@ -1103,7 +1070,7 @@ exports.defineAutoTests = function () {
// windows store and ios are too fast, win is called before we have a chance to abort
// so let's get them busy - while not providing an extra load to the slow Android emulators
- var arrayLength = ((isWindows && !isWindowsPhone81) || isIos) ? 3000000 : isIot ? 150000 : 200000;
Review comment:
```
var arrayLength = ((isWindows && !isWindowsPhone81) || isIos) ? 3000000 : isIot ? 150000 : 200000;
```
would become this, IF the above remains
```
var arrayLength = ((isWindows && !isWindowsPhone) || isIos) ? 3000000 : isIot ? 150000 : 200000;
```
##########
File path: tests/tests.js
##########
@@ -54,8 +54,6 @@ exports.defineAutoTests = function () {
// flags
var isWindows = cordova.platformId === "windows8" || cordova.platformId === "windows";
- var isWindowsPhone81 = isWindows && WinJS.Utilities.isPhone;
- var isWP8 = cordova.platformId === "windowsphone";
Review comment:
Can you confirm this?
```
var isWindows = cordova.platformId === "windows8" || cordova.platformId === "windows";
```
I suspect should become:
```
var isWindows = cordova.platformId === "windows";
```
But then I think the Windows platform can be on a phone? so I believe
```
var isWindowsPhone81 = isWindows && WinJS.Utilities.isPhone;
```
should become
```
var isWindowsPhone = isWindows && WinJS.Utilities.isPhone;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file-transfer] timbru31 merged pull request #270: fix!: remove deprecated platforms
Posted by GitBox <gi...@apache.org>.
timbru31 merged pull request #270:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file-transfer] timbru31 commented on a change in pull request #270: fix!: remove deprecated platforms
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #270:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/270#discussion_r477234064
##########
File path: tests/tests.js
##########
@@ -54,8 +54,6 @@ exports.defineAutoTests = function () {
// flags
var isWindows = cordova.platformId === "windows8" || cordova.platformId === "windows";
- var isWindowsPhone81 = isWindows && WinJS.Utilities.isPhone;
- var isWP8 = cordova.platformId === "windowsphone";
Review comment:
Good catch(es). I'll take a closer look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file-transfer] timbru31 commented on a change in pull request #270: fix!: remove deprecated platforms
Posted by GitBox <gi...@apache.org>.
timbru31 commented on a change in pull request #270:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/270#discussion_r479982052
##########
File path: tests/tests.js
##########
@@ -1103,7 +1070,7 @@ exports.defineAutoTests = function () {
// windows store and ios are too fast, win is called before we have a chance to abort
// so let's get them busy - while not providing an extra load to the slow Android emulators
- var arrayLength = ((isWindows && !isWindowsPhone81) || isIos) ? 3000000 : isIot ? 150000 : 200000;
Review comment:
done
##########
File path: tests/tests.js
##########
@@ -54,8 +54,6 @@ exports.defineAutoTests = function () {
// flags
var isWindows = cordova.platformId === "windows8" || cordova.platformId === "windows";
- var isWindowsPhone81 = isWindows && WinJS.Utilities.isPhone;
- var isWP8 = cordova.platformId === "windowsphone";
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file-transfer] timbru31 closed pull request #270: fix!: remove deprecated platforms
Posted by GitBox <gi...@apache.org>.
timbru31 closed pull request #270:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org