You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@milagro.apache.org by GitBox <gi...@apache.org> on 2022/04/05 16:14:20 UTC

[GitHub] [incubator-milagro-crypto-c] kittywhiskers opened a new pull request, #93: refactor: allow for C-style convention when mixed with C++ source files

kittywhiskers opened a new pull request, #93:
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/93

   ## Description
   
   There doesn't seem to be mentions of an official Milagro C++ wrapper and following in line with https://github.com/apache/incubator-milagro-crypto-c/issues/24, work on a potential C++ implementation _behind_ a C API will require C++ and C code to co-exist. Additionally, the prefix of `.c.in` proves to be misleading as it prevents IDEs (like Visual Studio Code) from recognising C source files. This PR attempts to address portions of these issues. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org


Re: [PR] refactor: allow for C-style convention when mixed with C++ source files [incubator-milagro-crypto-c]

Posted by "kwvg (via GitHub) via general" <ge...@incubator.apache.org>.
kwvg closed pull request #93: refactor: allow for C-style convention when mixed with C++ source files
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/93


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on pull request #93: refactor: allow for C-style convention when mixed with C++ source files

Posted by "giorgiozoppi (via GitHub)" <gi...@apache.org>.
giorgiozoppi commented on PR #93:
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/93#issuecomment-1619161670

   @kittywhiskers  can we have a call on this? I am interested to have a C++ wrapper but i don't know how we can move on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org


[GitHub] [incubator-milagro-crypto-c] giorgiozoppi commented on pull request #93: refactor: allow for C-style convention when mixed with C++ source files

Posted by "giorgiozoppi (via GitHub)" <gi...@apache.org>.
giorgiozoppi commented on PR #93:
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/93#issuecomment-1484222944

   Please solve the conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org