You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Koji Noguchi (JIRA)" <ji...@apache.org> on 2008/10/27 22:29:44 UTC

[jira] Created: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

fsck failing with NullPointerException  (return value 0)
--------------------------------------------------------

                 Key: HADOOP-4526
                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
             Project: Hadoop Core
          Issue Type: Bug
          Components: dfs
    Affects Versions: 0.18.1
         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
            Reporter: Koji Noguchi


fsck is siliently dying with return value of 0.

Namenode log showing 
2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
java.lang.NullPointerException

No stack trace.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hairong Kuang updated HADOOP-4526:
----------------------------------

    Fix Version/s: 0.18.2

> fsck failing with NullPointerException  (return value 0)
> --------------------------------------------------------
>
>                 Key: HADOOP-4526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.1
>         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
>            Reporter: Koji Noguchi
>            Assignee: Hairong Kuang
>             Fix For: 0.18.2
>
>
> fsck is siliently dying with return value of 0.
> Namenode log showing 
> 2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
> java.lang.NullPointerException
> No stack trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hairong Kuang reassigned HADOOP-4526:
-------------------------------------

    Assignee: Hairong Kuang

> fsck failing with NullPointerException  (return value 0)
> --------------------------------------------------------
>
>                 Key: HADOOP-4526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.1
>         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
>            Reporter: Koji Noguchi
>            Assignee: Hairong Kuang
>
> fsck is siliently dying with return value of 0.
> Namenode log showing 
> 2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
> java.lang.NullPointerException
> No stack trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

Posted by "Koji Noguchi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643075#action_12643075 ] 

Koji Noguchi commented on HADOOP-4526:
--------------------------------------

Reproduced the problem on a singlenode cluster by inserting some sleep.
Very similar issue with HADOOP-3107.
It somehow prints out the full stacktrace to the log only when there's no successful fsck before that.
(I believe it's an uncaught exception)


{noformat}
2008-10-27 21:50:17,285 WARN /: /fsck?path=%2Fuser:
java.lang.NullPointerException
  at org.apache.hadoop.dfs.NamenodeFsck.check(NamenodeFsck.java:172)
  at org.apache.hadoop.dfs.NamenodeFsck.check(NamenodeFsck.java:166)
  at org.apache.hadoop.dfs.NamenodeFsck.fsck(NamenodeFsck.java:129)
  at org.apache.hadoop.dfs.FsckServlet.doGet(FsckServlet.java:48)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
  at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
  at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:427)
  at org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(WebApplicationHandler.java:475)
  at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:567)
  at org.mortbay.http.HttpContext.handle(HttpContext.java:1565)
  at org.mortbay.jetty.servlet.WebApplicationContext.handle(WebApplicationContext.java:635)
  at org.mortbay.http.HttpContext.handle(HttpContext.java:1517)
  at org.mortbay.http.HttpServer.service(HttpServer.java:954)
  at org.mortbay.http.HttpConnection.service(HttpConnection.java:814)
  at org.mortbay.http.HttpConnection.handleNext(HttpConnection.java:981)
  at org.mortbay.http.HttpConnection.handle(HttpConnection.java:831)
  at org.mortbay.http.SocketListener.handleConnection(SocketListener.java:244)
  at org.mortbay.util.ThreadedServer.handle(ThreadedServer.java:357)
  at org.mortbay.util.ThreadPool$PoolThread.run(ThreadPool.java:534)
{noformat}

{code:title=NamenodeFsck.java|borderStyle=solid}
171     LocatedBlocks blocks = nn.namesystem.getBlockLocations(path, 0, fileLen);
172     isOpen = blocks.isUnderConstruction();
{code}

> fsck failing with NullPointerException  (return value 0)
> --------------------------------------------------------
>
>                 Key: HADOOP-4526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.1
>         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
>            Reporter: Koji Noguchi
>
> fsck is siliently dying with return value of 0.
> Namenode log showing 
> 2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
> java.lang.NullPointerException
> No stack trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643499#action_12643499 ] 

Hudson commented on HADOOP-4526:
--------------------------------

Integrated in Hadoop-trunk #646 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/646/])
    . fsck failing with NullPointerException. Contributed by Hairong Kuang.


> fsck failing with NullPointerException  (return value 0)
> --------------------------------------------------------
>
>                 Key: HADOOP-4526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.1
>         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
>            Reporter: Koji Noguchi
>            Assignee: Hairong Kuang
>             Fix For: 0.18.2, 0.19.0, 0.20.0
>
>         Attachments: fsckNPE-br18.patch, fsckNPE.patch
>
>
> fsck is siliently dying with return value of 0.
> Namenode log showing 
> 2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
> java.lang.NullPointerException
> No stack trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hairong Kuang updated HADOOP-4526:
----------------------------------

    Attachment: fsckNPE-br18.patch

The patch for branch 0.18.

> fsck failing with NullPointerException  (return value 0)
> --------------------------------------------------------
>
>                 Key: HADOOP-4526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.1
>         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
>            Reporter: Koji Noguchi
>            Assignee: Hairong Kuang
>             Fix For: 0.18.2
>
>         Attachments: fsckNPE-br18.patch, fsckNPE.patch
>
>
> fsck is siliently dying with return value of 0.
> Namenode log showing 
> 2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
> java.lang.NullPointerException
> No stack trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hairong Kuang updated HADOOP-4526:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.20.0
                   0.19.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I just committed this.

> fsck failing with NullPointerException  (return value 0)
> --------------------------------------------------------
>
>                 Key: HADOOP-4526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.1
>         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
>            Reporter: Koji Noguchi
>            Assignee: Hairong Kuang
>             Fix For: 0.18.2, 0.19.0, 0.20.0
>
>         Attachments: fsckNPE-br18.patch, fsckNPE.patch
>
>
> fsck is siliently dying with return value of 0.
> Namenode log showing 
> 2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
> java.lang.NullPointerException
> No stack trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hairong Kuang updated HADOOP-4526:
----------------------------------

    Attachment: fsckNPE.patch

This simple patch fixes the NPE problem.

> fsck failing with NullPointerException  (return value 0)
> --------------------------------------------------------
>
>                 Key: HADOOP-4526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.1
>         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
>            Reporter: Koji Noguchi
>            Assignee: Hairong Kuang
>             Fix For: 0.18.2
>
>         Attachments: fsckNPE.patch
>
>
> fsck is siliently dying with return value of 0.
> Namenode log showing 
> 2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
> java.lang.NullPointerException
> No stack trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hairong Kuang updated HADOOP-4526:
----------------------------------

    Status: Patch Available  (was: Open)

> fsck failing with NullPointerException  (return value 0)
> --------------------------------------------------------
>
>                 Key: HADOOP-4526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.1
>         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
>            Reporter: Koji Noguchi
>            Assignee: Hairong Kuang
>             Fix For: 0.18.2
>
>         Attachments: fsckNPE.patch
>
>
> fsck is siliently dying with return value of 0.
> Namenode log showing 
> 2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
> java.lang.NullPointerException
> No stack trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643106#action_12643106 ] 

Konstantin Shvachko commented on HADOOP-4526:
---------------------------------------------

+1
We generally accept files with no blocks. It should be reflected in fsck.

> fsck failing with NullPointerException  (return value 0)
> --------------------------------------------------------
>
>                 Key: HADOOP-4526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.1
>         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
>            Reporter: Koji Noguchi
>            Assignee: Hairong Kuang
>             Fix For: 0.18.2
>
>         Attachments: fsckNPE.patch
>
>
> fsck is siliently dying with return value of 0.
> Namenode log showing 
> 2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
> java.lang.NullPointerException
> No stack trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4526) fsck failing with NullPointerException (return value 0)

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643357#action_12643357 ] 

Hairong Kuang commented on HADOOP-4526:
---------------------------------------

I ran anttest-core on the patch on my local machine. The build was successfully finished.

Here was the result of ant test-patch:

     [exec] -1 overall.

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     -1 tests included.  The patch doesn't appear to include anynew or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugswarnings.

     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.


I have manually tested the patch and it showed the patch solved the NPE problem. 

> fsck failing with NullPointerException  (return value 0)
> --------------------------------------------------------
>
>                 Key: HADOOP-4526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4526
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.1
>         Environment: 0.18.1_H4277_H4271_H4326_H4314_H4395_H4351_H4407_H3217
>            Reporter: Koji Noguchi
>            Assignee: Hairong Kuang
>             Fix For: 0.18.2
>
>         Attachments: fsckNPE.patch
>
>
> fsck is siliently dying with return value of 0.
> Namenode log showing 
> 2008-10-27 07:57:00,514 WARN /: /fsck?path=%2F:
> java.lang.NullPointerException
> No stack trace.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.