You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/11/30 13:42:38 UTC

[GitHub] eiri commented on issue #1782: Only validate partitioned db name if db is partitioned

eiri commented on issue #1782: Only validate partitioned db name if db is partitioned
URL: https://github.com/apache/couchdb/pull/1782#issuecomment-443206934
 
 
   In my (bias) opinion it'd be cleaner to contain this logic within partition module, i.e. change  `couch_partition:validate_dbname/1` to `/2`, pass Opts and do this check there.
   
   Also, `proplists:get_value/2` is as long as it is slow, let's use `couch_util:get_value/3` as we do everywhere else :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services