You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by ChenjunZou <gi...@git.apache.org> on 2017/11/11 09:49:37 UTC

[GitHub] spark pull request #19721: [SPARK-22496][SQL]thrift server adds operation lo...

GitHub user ChenjunZou opened a pull request:

    https://github.com/apache/spark/pull/19721

    [SPARK-22496][SQL]thrift server adds operation logs

    ## What changes were proposed in this pull request?
    since hive 2.0+ uses upgrade log4j to log4j2，a lot of [changes](https://issues.apache.org/jira/browse/HIVE-11304) are made working on it.
    As spark is not to ready to update its inner hive version(1.2.1) , so I manages to make little changes.
    the function registerCurrentOperationLog  is moved from SQLOperstion to its parent class ExecuteStatementOperation so spark can use it.
    
    ## How was this patch tested?
    manual test


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ChenjunZou/spark operation-log

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19721.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19721
    
----
commit 0ee967c658da40b3f5f5a79276df340b66208b3f
Author: zouchenjun <zo...@youzan.com>
Date:   2017-11-11T09:36:58Z

    spark thrift server adds operation logs

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19721: [SPARK-22496][SQL]thrift server adds operation logs

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19721
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19721: [SPARK-22496][SQL]thrift server adds operation logs

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19721
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19721: [SPARK-22496][SQL]thrift server adds operation logs

Posted by liufengdb <gi...@git.apache.org>.

Github user liufengdb commented on the issue:

    https://github.com/apache/spark/pull/19721
  
    lgtm!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19721: [SPARK-22496][SQL]thrift server adds operation logs

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19721
  
    Sorry, I need to revert the changes. It breaks CRAN. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19721: [SPARK-22496][SQL]thrift server adds operation logs

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19721
  
    ok to test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19721: [SPARK-22496][SQL]thrift server adds operation logs

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19721
  
    **[Test build #84661 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84661/testReport)** for PR 19721 at commit [`0ee967c`](https://github.com/apache/spark/commit/0ee967c658da40b3f5f5a79276df340b66208b3f).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19721: [SPARK-22496][SQL]thrift server adds operation logs

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19721
  
    cc @liufengdb 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19721: [SPARK-22496][SQL]thrift server adds operation logs

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19721
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org