You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/18 08:27:27 UTC

[GitHub] [airflow] eladkal opened a new issue #22356: Change DeprecationWarning to AirflowDeprecationWarning

eladkal opened a new issue #22356:
URL: https://github.com/apache/airflow/issues/22356


   ### Body
   
   It's becoming hard to differentiate between all warnings raised in logs.
   Airflow uses many packages that also raise warnings.
   
   I suggest to create `AirflowDeprecationWarning`.
   We can even have similar mechanism to sqlalchemy that has `SADeprecationWarning`  and specifying the version this warning started from that way it will also be easier to keep track.
   https://github.com/sqlalchemy/sqlalchemy/blob/769fa67d842035dd852ab8b6a26ea3f110a51131/lib/sqlalchemy/exc.py#L779
   
   
   We can also have `AirflowProviderDeprecationWarning` to differentiate from Airflow core
   
   Originally posted in https://github.com/apache/airflow/pull/22333#discussion_r829106399
   
   What do others think?
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #22356: Change DeprecationWarning to AirflowDeprecationWarning

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #22356:
URL: https://github.com/apache/airflow/issues/22356#issuecomment-1072423452


   I agree think we should copy what other projects do (SQLA, Celery, Djanog etc), and have a `RemovedInAirflow3` warning subclass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #22356: Change DeprecationWarning to AirflowDeprecationWarning

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #22356:
URL: https://github.com/apache/airflow/issues/22356#issuecomment-1072511288


   Oh -- we can't (easily) use such a warning class in providers as they still need to work on Airflow 2.1 (at the moment anyway)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #22356: Change DeprecationWarning to AirflowDeprecationWarning

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #22356:
URL: https://github.com/apache/airflow/issues/22356#issuecomment-1072423452


   I agree think we should copy what other projects do (SQLA, Celery, Djanog etc), and have a `RemovedInAirflow3` warning subclass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #22356: Change DeprecationWarning to AirflowDeprecationWarning

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #22356:
URL: https://github.com/apache/airflow/issues/22356#issuecomment-1072531943


   in `AirflowProviderDeprecationWarning` i meant for warnings which are in scope of the provider itself and are not tied to Airflow core (like Operator rename).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org