[jira] [Commented] (LIBCLOUD-664) EC2 driver breaks contract with base driver in `list_volume_snapshots`

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318205#comment-14318205 ] 

ASF GitHub Bot commented on LIBCLOUD-664:
-----------------------------------------

GitHub user allardhoeve opened a pull request:

    https://github.com/apache/libcloud/pull/451

    [LIBCLOUD-664] EC2 driver breaks contract with base driver in `list_volume_snapshots`

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ByteInternet/libcloud ec2-driver-conforms-to-contract-list-volume-snapshots

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/451.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #451
    
----
commit 0435d28daf8716a51e7f097c8dd6b6d872d0db78
Author: Allard Hoeve <al...@byte.nl>
Date:   2015-02-12T13:49:15Z

    Make EC2 conform to interface

commit 784e8c8a9771ae5de03bd28e9302b986c6d3fc80
Author: Allard Hoeve <al...@byte.nl>
Date:   2015-02-12T13:54:31Z

    docs

----


> EC2 driver breaks contract with base driver in `list_volume_snapshots`
> ----------------------------------------------------------------------
>
>                 Key: LIBCLOUD-664
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-664
>             Project: Libcloud
>          Issue Type: Bug
>            Reporter: Henk Slaaf
>            Priority: Minor
>
> The base driver has the following definition for `list_volume_snapshots`:
> {code}
> def list_volume_snapshots(self, volume):
>         """
>         List snapshots for a storage volume.
>         
>         :rtype: ``list`` of :class:`VolumeSnapshot`
>         """
>         raise NotImplementedError(
>             'list_volume_snapshots not implemented for this driver')
> {code}
> This function is volume-centric and should return all snapshots for the given Volume.
> In contrast, EC2 has the following, which is snapshot-centric and returns only the given snapshot.
> {code}
>     def list_volume_snapshots(self, snapshot):
>         return self.list_snapshots(snapshot)
> {code}
> We should change this to both be volume-centric. In its current form, this function is identical to list_snapshots and thus redundant.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)