You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/02/27 10:52:05 UTC
Review Request 57081: Not able to delete custom property
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57081/
-----------------------------------------------------------
Review request for Ambari and Denys Buzhor.
Bugs: ambari-20147
https://issues.apache.org/jira/browse/ambari-20147
Repository: ambari
Description
-------
Steps to reproduce the issue:
1. Under Hive service , Create a custom Group called "hive-group1"
2. Add a property say "hive.mv.files.thread"
3. save the configurations
4. Again go to hive configurations, select hive-group1 group and then try to delete the configuration by clicking "-" , it does nothing - in console fails with JS error as
Uncaught TypeError: Cannot read property 'without' of null
at Class.removeOverride (app.js:185869)
at handler (vendor.js:21227)
at HTMLAnchorElement.<anonymous> (vendor.js:13019)
at HTMLDivElement.dispatch (vendor.js:126)
at HTMLDivElement.i (vendor.js:126)
Diffs
-----
ambari-web/app/mixins/common/configs/configs_comparator.js b619aca
ambari-web/app/views/common/configs/overriddenPropertyRow_view.js 86e9c60
Diff: https://reviews.apache.org/r/57081/diff/
Testing
-------
20490 passing (23s)
153 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 57081: Not able to delete custom property
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57081/#review166848
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On Feb. 27, 2017, 10:52 a.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57081/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 10:52 a.m.)
>
>
> Review request for Ambari and Denys Buzhor.
>
>
> Bugs: ambari-20147
> https://issues.apache.org/jira/browse/ambari-20147
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps to reproduce the issue:
> 1. Under Hive service , Create a custom Group called "hive-group1"
> 2. Add a property say "hive.mv.files.thread"
> 3. save the configurations
> 4. Again go to hive configurations, select hive-group1 group and then try to delete the configuration by clicking "-" , it does nothing - in console fails with JS error as
> Uncaught TypeError: Cannot read property 'without' of null
> at Class.removeOverride (app.js:185869)
> at handler (vendor.js:21227)
> at HTMLAnchorElement.<anonymous> (vendor.js:13019)
> at HTMLDivElement.dispatch (vendor.js:126)
> at HTMLDivElement.i (vendor.js:126)
>
>
> Diffs
> -----
>
> ambari-web/app/mixins/common/configs/configs_comparator.js b619aca
> ambari-web/app/views/common/configs/overriddenPropertyRow_view.js 86e9c60
>
> Diff: https://reviews.apache.org/r/57081/diff/
>
>
> Testing
> -------
>
> 20490 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>