[jira] [Commented] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571936#comment-16571936 ] 

Julian Hyde commented on CALCITE-2453:
--------------------------------------

In future please provide a PR not a patch; you must include tests.

CALCITE-2310 proposes a sequence of statements, separated by semicolons. I think that there should be new productions in the parser for 1 a sequence of statements, and 2 a statement followed by a semicolon. Not what you've done here, which is to silently eat up a trailing semicolon. That would fix this and 2310.

> Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements
> ------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-2453
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2453
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: next
>            Reporter: charbel yazbeck
>            Assignee: Julian Hyde
>            Priority: Trivial
>         Attachments: 0001-CALCITE-2453-Allowing-SQL-statements-to-optionally-e.patch
>
>
> Consists of adding [<SEMICOLON>] in Parser.jj



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)