[jira] [Commented] (PHOENIX-4113) Killing forked JVM may cause resources to be not released

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137416#comment-16137416 ] 

Hadoop QA commented on PHOENIX-4113:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12883189/PHOENIX-4113_4.x-HBase-0.98.patch
  against 4.x-HBase-0.98 branch at commit 16e0511ff3e65d2463ab4481b9dd9a42cdf18461.
  ATTACHMENT ID: 12883189

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 8 new or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1282//console

This message is automatically generated.

> Killing forked JVM may cause resources to be not released
> ---------------------------------------------------------
>
>                 Key: PHOENIX-4113
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4113
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-4113_4.x-HBase-0.98.patch
>
>
> We have a <shutdown>kill</shutdown> configured in pom which behind the scenes calls 
> {code}
> java.lang.Runtime.halt(1)
> {code}
> We also have a shutdown hook which is calling halt on the JVM.
> {code}
> private static String checkClusterInitialized(ReadOnlyProps serverProps) throws Exception {
>         if (!clusterInitialized) {
>             url = setUpTestCluster(config, serverProps);
>             clusterInitialized = true;
>             Runtime.getRuntime().addShutdownHook(new Thread() {
>                 @Override
>                 public void run() {
>                     logger.info("SHUTDOWN: halting JVM now");
>                     Runtime.getRuntime().halt(0);
>                 }
>             });
>         }
>         return url;
>     }
> {code}
> This causes JVM to not execute all shutdown hooks which in turn would cause the JVM process to not release all the system resources (network ports, file handles, etc) it was using. If OS is not able to clean up these orphaned resources soon enough, it could cause subsequent new JVM processes to run into resource issues.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)