You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/13 09:42:28 UTC
[GitHub] [iotdb] cmlmakahts opened a new pull request, #5899: [IOTDB-2880] move procedure module into confignode as a class-package
cmlmakahts opened a new pull request, #5899:
URL: https://github.com/apache/iotdb/pull/5899
1. move module _procedure_ into _confignode_ as a class package
2. Add Licenses about referred classes of hbase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] cmlmakahts commented on a diff in pull request #5899: [IOTDB-2880] move procedure module into confignode as a class-package
Posted by GitBox <gi...@apache.org>.
cmlmakahts commented on code in PR #5899:
URL: https://github.com/apache/iotdb/pull/5899#discussion_r873331312
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java:
##########
@@ -24,14 +24,14 @@
import org.apache.iotdb.confignode.conf.ConfigNodeConf;
import org.apache.iotdb.confignode.conf.ConfigNodeDescriptor;
import org.apache.iotdb.confignode.persistence.ProcedureInfo;
-import org.apache.iotdb.confignode.procedure.ConfigProcedureStore;
-import org.apache.iotdb.confignode.procedure.DeleteStorageGroupProcedure;
-import org.apache.iotdb.confignode.procedure.env.ConfigNodeProcedureEnv;
import org.apache.iotdb.confignode.rpc.thrift.TStorageGroupSchema;
import org.apache.iotdb.procedure.Procedure;
import org.apache.iotdb.procedure.ProcedureExecutor;
+import org.apache.iotdb.procedure.env.ConfigNodeProcedureEnv;
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #5899: [IOTDB-2880] move procedure module into confignode as a class-package
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #5899:
URL: https://github.com/apache/iotdb/pull/5899#discussion_r873278712
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java:
##########
@@ -24,14 +24,14 @@
import org.apache.iotdb.confignode.conf.ConfigNodeConf;
import org.apache.iotdb.confignode.conf.ConfigNodeDescriptor;
import org.apache.iotdb.confignode.persistence.ProcedureInfo;
-import org.apache.iotdb.confignode.procedure.ConfigProcedureStore;
-import org.apache.iotdb.confignode.procedure.DeleteStorageGroupProcedure;
-import org.apache.iotdb.confignode.procedure.env.ConfigNodeProcedureEnv;
import org.apache.iotdb.confignode.rpc.thrift.TStorageGroupSchema;
import org.apache.iotdb.procedure.Procedure;
import org.apache.iotdb.procedure.ProcedureExecutor;
+import org.apache.iotdb.procedure.env.ConfigNodeProcedureEnv;
Review Comment:
We could move procedure package under the org.apache.iotdb.confignode package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #5899: [IOTDB-2880] move procedure module into confignode as a class-package
Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #5899:
URL: https://github.com/apache/iotdb/pull/5899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org