You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2023/09/11 07:06:30 UTC

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1652: MINIFICPP-2195 fix flaky MQTT docker tests

martinzink commented on code in PR #1652:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1652#discussion_r1321083062


##########
docker/test/integration/features/steps/steps.py:
##########
@@ -428,6 +428,7 @@ def step_impl(context):
 @given("an MQTT broker is set up in correspondence with the PublishMQTT and ConsumeMQTT")
 def step_impl(context):
     context.test.acquire_container(context=context, name="mqtt-broker", engine="mqtt-broker")
+    context.test.start('mqtt-broker')

Review Comment:
   I've merged the steps you mentioned in https://github.com/apache/nifi-minifi-cpp/pull/1652/commits/21d6cf4284885ad0855d4f7cb89b76362a19769b



##########
docker/test/integration/features/steps/steps.py:
##########


Review Comment:
   Good idea I've merged the steps you mentioned in https://github.com/apache/nifi-minifi-cpp/pull/1652/commits/21d6cf4284885ad0855d4f7cb89b76362a19769b



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org