You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by PJ Dillon <pj...@sulia.com> on 2013/09/03 16:59:55 UTC
Re: New iOS 7 UI and backwards compatibility
For our purposes, CDVSplashScreen.m (as of 2.9.0) just needed a test for
the OS version when calculating the image bounds:
diff --git a/CordovaLib/Classes/CDVSplashScreen.m
b/CordovaLib/Classes/CDVSplashScreen.m
index fdb79fa..809ce35 100644
--- a/CordovaLib/Classes/CDVSplashScreen.m
+++ b/CordovaLib/Classes/CDVSplashScreen.m
@@ -170,7 +170,9 @@
// There's a special case when the image is the size of the screen.
if (CGSizeEqualToSize(screenSize, imgBounds.size)) {
CGRect statusFrame = [self.viewController.view
convertRect:[UIApplication sharedApplication].statusBarFrame fromView:nil];
- imgBounds.origin.y -= statusFrame.size.height;
+ if (floor(NSFoundationVersionNumber) <=
NSFoundationVersionNumber_iOS_6_1) {
+ imgBounds.origin.y -= statusFrame.size.height;
+ }
} else {
CGRect viewBounds = self.viewController.view.bounds;
CGFloat imgAspect = imgBounds.size.width / imgBounds.size.height;
On Tue, Jul 16, 2013 at 11:38 AM, Kerri Shotts <ke...@gmail.com>wrote:
> Would help if I paid attention to which group things are in... ;) thought
> it was in the main forum for some reason (not enough caffeine).
>
> Do file bugs; filing bugs is pretty safe (since how else can devs fix
> issues related to iOS7.)
>
> That said, I would still expect the support to be an issue, since something
> could easily break in beta 4. In fact people on the forums have been
> complaining about breaks between beta 2 and 3.
>
> Also, do search the forums for the status bar piece (unless that has been
> dealt with in 2.9.0/3.0) since there is a really simple line of code you
> can add to get back to iOS6 metrics. (Side note: clearly Apple wants us to
> go this new direction, so whether or not PG should even build this in by
> default is debatable in my opinion. We all, native and non-native devs
> alike have to live in this new world and adjust our UI to reflect what
> makes sense here for each app. Perhaps a config.xml setting might be
> useful, though, although it should be equally doable in JS/CSS/HTML to do
> the required changes. Do note that this is not just a hardship faced by us:
> all native devs are also having to take a hard look at their app and
> statistics to see if supporting iOS 6 and 7 is feasible or not, and judging
> from the forum, a large number are going iOS7 only. )
>
> Sent from my phone.
>
> ___________________________________
> Kerri Shotts
> photoKandy Studios, LLC
>
> On the Web: http://www.photokandy.com/
>
> Social Media:
> Twitter: @photokandy, http://twitter.com/photokandy
> Tumblr: http://photokandy.tumblr.com/
> Github: https://github.com/kerrishotts
> https://github.com/organizations/photokandyStudios
> CoderWall: https://coderwall.com/kerrishotts
>
> Apps on the Apple Store:
>
> https://itunes.apple.com/us/artist/photokandy-studios-llc/id498577828
>
> Books:
>
> http://www.packtpub.com/phonegap-2-mobile-application-hotshot/book
> http://www.packtpub.com/phonegap-social-app-development/book
>
> On Jul 16, 2013, at 10:14, Andrew Grieve <ag...@chromium.org> wrote:
>
> There have been no splash screen fixes since 2.9.0 that I'm aware of.
> Please file a bug on our jira:https://issues.apache.org/jira/browse/CB
>
>
> On Tue, Jul 16, 2013 at 10:56 AM, PJ Dillon <pj...@sulia.com> wrote:
>
> Hi,
>
>
> I haven't found any discussion about this searching through my mail. But
>
> the UI is broken in iOS 7. I actually don't know if I'm allowed to discuss
>
> the details. It's glaringly obvious, though, and it makes compatibility
>
> with iOS 6 somewhat of a chore for cordova-based apps, especially with the
>
> position splash screen.... unless I'm mistaken.
>
>
> So, before I go hacking around with our view controller to accommodate both
>
> 6 & 7, has this been taken care of already, and I'm just overlooking it?
>
>
> We're trying to get an app out the door as soon as iOS 7 launches.
>
>
> Thanks,
>
>
> PJ Dillon
>
> Sulia, Inc
>
Re: New iOS 7 UI and backwards compatibility
Posted by Shazron <sh...@gmail.com>.
Will do, it's on my compatibility list of things to do. Thanks PJ
On Wed, Sep 4, 2013 at 3:42 AM, Andrew Grieve <ag...@chromium.org> wrote:
> Shaz, can you test this fix? (I haven't gotten on the 4.5 bandwagon yet)
>
>
> On Tue, Sep 3, 2013 at 10:59 AM, PJ Dillon <pj...@sulia.com> wrote:
>
> > For our purposes, CDVSplashScreen.m (as of 2.9.0) just needed a test for
> > the OS version when calculating the image bounds:
> >
> > diff --git a/CordovaLib/Classes/CDVSplashScreen.m
> > b/CordovaLib/Classes/CDVSplashScreen.m
> > index fdb79fa..809ce35 100644
> > --- a/CordovaLib/Classes/CDVSplashScreen.m
> > +++ b/CordovaLib/Classes/CDVSplashScreen.m
> > @@ -170,7 +170,9 @@
> > // There's a special case when the image is the size of the screen.
> > if (CGSizeEqualToSize(screenSize, imgBounds.size)) {
> > CGRect statusFrame = [self.viewController.view
> > convertRect:[UIApplication sharedApplication].statusBarFrame
> fromView:nil];
> > - imgBounds.origin.y -= statusFrame.size.height;
> > + if (floor(NSFoundationVersionNumber) <=
> > NSFoundationVersionNumber_iOS_6_1) {
> > + imgBounds.origin.y -= statusFrame.size.height;
> > + }
> > } else {
> > CGRect viewBounds = self.viewController.view.bounds;
> > CGFloat imgAspect = imgBounds.size.width /
> imgBounds.size.height;
> >
> >
> > On Tue, Jul 16, 2013 at 11:38 AM, Kerri Shotts <kerrishotts@gmail.com
> > >wrote:
> >
> > > Would help if I paid attention to which group things are in... ;)
> thought
> > > it was in the main forum for some reason (not enough caffeine).
> > >
> > > Do file bugs; filing bugs is pretty safe (since how else can devs fix
> > > issues related to iOS7.)
> > >
> > > That said, I would still expect the support to be an issue, since
> > something
> > > could easily break in beta 4. In fact people on the forums have been
> > > complaining about breaks between beta 2 and 3.
> > >
> > > Also, do search the forums for the status bar piece (unless that has
> been
> > > dealt with in 2.9.0/3.0) since there is a really simple line of code
> you
> > > can add to get back to iOS6 metrics. (Side note: clearly Apple wants us
> > to
> > > go this new direction, so whether or not PG should even build this in
> by
> > > default is debatable in my opinion. We all, native and non-native devs
> > > alike have to live in this new world and adjust our UI to reflect what
> > > makes sense here for each app. Perhaps a config.xml setting might be
> > > useful, though, although it should be equally doable in JS/CSS/HTML to
> do
> > > the required changes. Do note that this is not just a hardship faced by
> > us:
> > > all native devs are also having to take a hard look at their app and
> > > statistics to see if supporting iOS 6 and 7 is feasible or not, and
> > judging
> > > from the forum, a large number are going iOS7 only. )
> > >
> > > Sent from my phone.
> > >
> > > ___________________________________
> > > Kerri Shotts
> > > photoKandy Studios, LLC
> > >
> > > On the Web: http://www.photokandy.com/
> > >
> > > Social Media:
> > > Twitter: @photokandy, http://twitter.com/photokandy
> > > Tumblr: http://photokandy.tumblr.com/
> > > Github: https://github.com/kerrishotts
> > >
> > https://github.com/organizations/photokandyStudios
> > > CoderWall: https://coderwall.com/kerrishotts
> > >
> > > Apps on the Apple Store:
> > >
> > > https://itunes.apple.com/us/artist/photokandy-studios-llc/id498577828
> > >
> > > Books:
> > >
> > > http://www.packtpub.com/phonegap-2-mobile-application-hotshot/book
> > > http://www.packtpub.com/phonegap-social-app-development/book
> > >
> > > On Jul 16, 2013, at 10:14, Andrew Grieve <ag...@chromium.org> wrote:
> > >
> > > There have been no splash screen fixes since 2.9.0 that I'm aware of.
> > > Please file a bug on our jira:https://issues.apache.org/jira/browse/CB
> > >
> > >
> > > On Tue, Jul 16, 2013 at 10:56 AM, PJ Dillon <pj...@sulia.com> wrote:
> > >
> > > Hi,
> > >
> > >
> > > I haven't found any discussion about this searching through my mail.
> But
> > >
> > > the UI is broken in iOS 7. I actually don't know if I'm allowed to
> > discuss
> > >
> > > the details. It's glaringly obvious, though, and it makes compatibility
> > >
> > > with iOS 6 somewhat of a chore for cordova-based apps, especially with
> > the
> > >
> > > position splash screen.... unless I'm mistaken.
> > >
> > >
> > > So, before I go hacking around with our view controller to accommodate
> > both
> > >
> > > 6 & 7, has this been taken care of already, and I'm just overlooking
> it?
> > >
> > >
> > > We're trying to get an app out the door as soon as iOS 7 launches.
> > >
> > >
> > > Thanks,
> > >
> > >
> > > PJ Dillon
> > >
> > > Sulia, Inc
> > >
> >
>
Re: New iOS 7 UI and backwards compatibility
Posted by Andrew Grieve <ag...@chromium.org>.
Shaz, can you test this fix? (I haven't gotten on the 4.5 bandwagon yet)
On Tue, Sep 3, 2013 at 10:59 AM, PJ Dillon <pj...@sulia.com> wrote:
> For our purposes, CDVSplashScreen.m (as of 2.9.0) just needed a test for
> the OS version when calculating the image bounds:
>
> diff --git a/CordovaLib/Classes/CDVSplashScreen.m
> b/CordovaLib/Classes/CDVSplashScreen.m
> index fdb79fa..809ce35 100644
> --- a/CordovaLib/Classes/CDVSplashScreen.m
> +++ b/CordovaLib/Classes/CDVSplashScreen.m
> @@ -170,7 +170,9 @@
> // There's a special case when the image is the size of the screen.
> if (CGSizeEqualToSize(screenSize, imgBounds.size)) {
> CGRect statusFrame = [self.viewController.view
> convertRect:[UIApplication sharedApplication].statusBarFrame fromView:nil];
> - imgBounds.origin.y -= statusFrame.size.height;
> + if (floor(NSFoundationVersionNumber) <=
> NSFoundationVersionNumber_iOS_6_1) {
> + imgBounds.origin.y -= statusFrame.size.height;
> + }
> } else {
> CGRect viewBounds = self.viewController.view.bounds;
> CGFloat imgAspect = imgBounds.size.width / imgBounds.size.height;
>
>
> On Tue, Jul 16, 2013 at 11:38 AM, Kerri Shotts <kerrishotts@gmail.com
> >wrote:
>
> > Would help if I paid attention to which group things are in... ;) thought
> > it was in the main forum for some reason (not enough caffeine).
> >
> > Do file bugs; filing bugs is pretty safe (since how else can devs fix
> > issues related to iOS7.)
> >
> > That said, I would still expect the support to be an issue, since
> something
> > could easily break in beta 4. In fact people on the forums have been
> > complaining about breaks between beta 2 and 3.
> >
> > Also, do search the forums for the status bar piece (unless that has been
> > dealt with in 2.9.0/3.0) since there is a really simple line of code you
> > can add to get back to iOS6 metrics. (Side note: clearly Apple wants us
> to
> > go this new direction, so whether or not PG should even build this in by
> > default is debatable in my opinion. We all, native and non-native devs
> > alike have to live in this new world and adjust our UI to reflect what
> > makes sense here for each app. Perhaps a config.xml setting might be
> > useful, though, although it should be equally doable in JS/CSS/HTML to do
> > the required changes. Do note that this is not just a hardship faced by
> us:
> > all native devs are also having to take a hard look at their app and
> > statistics to see if supporting iOS 6 and 7 is feasible or not, and
> judging
> > from the forum, a large number are going iOS7 only. )
> >
> > Sent from my phone.
> >
> > ___________________________________
> > Kerri Shotts
> > photoKandy Studios, LLC
> >
> > On the Web: http://www.photokandy.com/
> >
> > Social Media:
> > Twitter: @photokandy, http://twitter.com/photokandy
> > Tumblr: http://photokandy.tumblr.com/
> > Github: https://github.com/kerrishotts
> >
> https://github.com/organizations/photokandyStudios
> > CoderWall: https://coderwall.com/kerrishotts
> >
> > Apps on the Apple Store:
> >
> > https://itunes.apple.com/us/artist/photokandy-studios-llc/id498577828
> >
> > Books:
> >
> > http://www.packtpub.com/phonegap-2-mobile-application-hotshot/book
> > http://www.packtpub.com/phonegap-social-app-development/book
> >
> > On Jul 16, 2013, at 10:14, Andrew Grieve <ag...@chromium.org> wrote:
> >
> > There have been no splash screen fixes since 2.9.0 that I'm aware of.
> > Please file a bug on our jira:https://issues.apache.org/jira/browse/CB
> >
> >
> > On Tue, Jul 16, 2013 at 10:56 AM, PJ Dillon <pj...@sulia.com> wrote:
> >
> > Hi,
> >
> >
> > I haven't found any discussion about this searching through my mail. But
> >
> > the UI is broken in iOS 7. I actually don't know if I'm allowed to
> discuss
> >
> > the details. It's glaringly obvious, though, and it makes compatibility
> >
> > with iOS 6 somewhat of a chore for cordova-based apps, especially with
> the
> >
> > position splash screen.... unless I'm mistaken.
> >
> >
> > So, before I go hacking around with our view controller to accommodate
> both
> >
> > 6 & 7, has this been taken care of already, and I'm just overlooking it?
> >
> >
> > We're trying to get an app out the door as soon as iOS 7 launches.
> >
> >
> > Thanks,
> >
> >
> > PJ Dillon
> >
> > Sulia, Inc
> >
>