You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/09 22:38:49 UTC
Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to
Boost interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66009/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
Bugs: MESOS-8658
https://issues.apache.org/jira/browse/MESOS-8658
Repository: mesos
Description
-------
As found in the Autotools builds, GCC and Clang will emit an used
local typedef warning for headers including Boost. Since it is
3rdparty code, we disable this warning in its interface.
Diffs
-----
3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
Diff: https://reviews.apache.org/r/66009/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs`
to Boost interface.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66009/
-----------------------------------------------------------
(Updated March 19, 2018, 12:09 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-8658
https://issues.apache.org/jira/browse/MESOS-8658
Repository: mesos
Description (updated)
-------
As found in the Autotools builds, GCC and Clang will emit an used
local typedef warning for headers including Boost. Since it is
3rdparty code, we disable this warning in its interface.
Diffs (updated)
-----
3rdparty/CMakeLists.txt e0c1538eaaef4bf6a198e89867a13763f264deb3
configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507
Diff: https://reviews.apache.org/r/66009/diff/3/
Changes: https://reviews.apache.org/r/66009/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs`
to Boost interface.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66009/#review199352
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On March 14, 2018, 4:11 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66009/
> -----------------------------------------------------------
>
> (Updated March 14, 2018, 4:11 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8658
> https://issues.apache.org/jira/browse/MESOS-8658
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As found in the Autotools builds, GCC and Clang will emit an used
> local typedef warning for headers including Boost. Since it is
> 3rdparty code, we disable this warning in its interface.
>
> The versions were updated with the latest known scenario.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
> configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507
>
>
> Diff: https://reviews.apache.org/r/66009/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs`
to Boost interface.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66009/
-----------------------------------------------------------
(Updated March 14, 2018, 4:11 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
Changes
-------
Updated versions.
Bugs: MESOS-8658
https://issues.apache.org/jira/browse/MESOS-8658
Repository: mesos
Description (updated)
-------
As found in the Autotools builds, GCC and Clang will emit an used
local typedef warning for headers including Boost. Since it is
3rdparty code, we disable this warning in its interface.
The versions were updated with the latest known scenario.
Diffs (updated)
-----
3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
configure.ac 30fbadc32d1d96f719d45fa8067f975283c25507
Diff: https://reviews.apache.org/r/66009/diff/2/
Changes: https://reviews.apache.org/r/66009/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs`
to Boost interface.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On March 14, 2018, 9:38 a.m., Benjamin Bannier wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 179-182 (patched)
> > <https://reviews.apache.org/r/66009/diff/1/?file=1973217#file1973217line179>
> >
> > Since `469363d4322c7acda7fd10acbe8822f610af5a43` we package boost-1.65.0 amd does not appear to be needed anymore. Could you confirm that it is still needed and update the Boost versions both here and in `configure.ac`, or alternatively drop this patch and also remove the respective code in `configure.ac`?
Whoops, I thought I'd updated the version here. Yes, I confirmed we still needed it. Boost's variant type is unusable without this disabled. I'll update the comments.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66009/#review199180
-----------------------------------------------------------
On March 9, 2018, 2:38 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66009/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 2:38 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8658
> https://issues.apache.org/jira/browse/MESOS-8658
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As found in the Autotools builds, GCC and Clang will emit an used
> local typedef warning for headers including Boost. Since it is
> 3rdparty code, we disable this warning in its interface.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
>
>
> Diff: https://reviews.apache.org/r/66009/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs`
to Boost interface.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66009/#review199180
-----------------------------------------------------------
3rdparty/CMakeLists.txt
Lines 179-182 (patched)
<https://reviews.apache.org/r/66009/#comment279476>
Since `469363d4322c7acda7fd10acbe8822f610af5a43` we package boost-1.65.0 amd does not appear to be needed anymore. Could you confirm that it is still needed and update the Boost versions both here and in `configure.ac`, or alternatively drop this patch and also remove the respective code in `configure.ac`?
- Benjamin Bannier
On March 9, 2018, 11:38 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66009/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 11:38 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8658
> https://issues.apache.org/jira/browse/MESOS-8658
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As found in the Autotools builds, GCC and Clang will emit an used
> local typedef warning for headers including Boost. Since it is
> 3rdparty code, we disable this warning in its interface.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
>
>
> Diff: https://reviews.apache.org/r/66009/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs`
to Boost interface.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66009/#review199030
-----------------------------------------------------------
Ship it!
Ship It!
- John Kordich
On March 9, 2018, 10:38 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66009/
> -----------------------------------------------------------
>
> (Updated March 9, 2018, 10:38 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-8658
> https://issues.apache.org/jira/browse/MESOS-8658
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As found in the Autotools builds, GCC and Clang will emit an used
> local typedef warning for headers including Boost. Since it is
> 3rdparty code, we disable this warning in its interface.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 61dc788edf96ca6e8e3ee736eb232c0c118e6191
>
>
> Diff: https://reviews.apache.org/r/66009/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>