You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/12/23 15:04:00 UTC

[GitHub] [dolphinscheduler-website] uestczhuhao opened a new pull request #609: [Bug-7389][docs-zh][docs] Fix System User Manual link failure in version 2.0.1 and version 2.0.0

uestczhuhao opened a new pull request #609:
URL: https://github.com/apache/dolphinscheduler-website/pull/609


   Fix System User Manual link failure in version 2.0.1 and version 2.0.0. Close apache/dolphinscheduler#7389
   
   I also fix incorrect Quick Start hyperlink in  /docs/en-us/2.0.0/user_doc/guide/system-manual.md, it mistake link to version 1.3.9


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] uestczhuhao commented on a change in pull request #609: [Bug-7389][docs-zh][docs] Fix System User Manual link failure in version 2.0.1 and version 2.0.0

Posted by GitBox <gi...@apache.org>.
uestczhuhao commented on a change in pull request #609:
URL: https://github.com/apache/dolphinscheduler-website/pull/609#discussion_r776606258



##########
File path: docs/zh-cn/2.0.1/user_doc/architecture/design.md
##########
@@ -68,7 +68,7 @@
 
 * **UI** 
 
-    系统的前端页面,提供系统的各种可视化操作界面,详见<a href="/zh-cn/docs/2.0.1/user_doc/system-manual.html" target="_self">系统使用手册</a>部分。
+    系统的前端页面,提供系统的各种可视化操作界面,详见[功能介绍](../guide/homepage.md)部分。

Review comment:
       done @zhongjiajie 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #609: [Bug-7389][docs-zh][docs] Fix System User Manual link failure in version 2.0.1 and version 2.0.0

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #609:
URL: https://github.com/apache/dolphinscheduler-website/pull/609#discussion_r775326878



##########
File path: docs/en-us/2.0.0/user_doc/architecture/design.md
##########
@@ -78,7 +78,7 @@ scheduling system
 * **UI**
 
   The front-end page of the system provides various visual operation interfaces of the system,See more
-  at<a href="/en-us/docs/2.0.0/user_doc/system-manual.html" target="_self"> System User Manual </a>section。
+  at [System User Manual](../guide/system-manual.md) section。

Review comment:
       And for this dead link, maybe we better to change it to `../guide/homepage.md` and the content change to `Introduction to Functions and it children page` or something like that
   ![image](https://user-images.githubusercontent.com/15820530/147432618-9e789d8f-f9ab-4f96-8667-909d983d2d50.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] uestczhuhao commented on pull request #609: [Bug-7389][docs-zh][docs] Fix System User Manual link failure in version 2.0.1 and version 2.0.0

Posted by GitBox <gi...@apache.org>.
uestczhuhao commented on pull request #609:
URL: https://github.com/apache/dolphinscheduler-website/pull/609#issuecomment-1002376572


   > @uestczhuhao Are you still WIP?
   
   yes, a little busy these days, i will fix and update pr tonight


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #609: [Bug-7389][docs-zh][docs] Fix System User Manual link failure in version 2.0.1 and version 2.0.0

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #609:
URL: https://github.com/apache/dolphinscheduler-website/pull/609#issuecomment-1002398190


   We looking forward your contribution ❤️ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #609: [Bug-7389][docs-zh][docs] Fix System User Manual link failure in version 2.0.1 and version 2.0.0

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #609:
URL: https://github.com/apache/dolphinscheduler-website/pull/609#issuecomment-1001316965


   Hi @uestczhuhao, we do not forget to add `system-manual.md` file, we split the doc to multiply files. for example `system-manual.md` have doc to desc how to use our task type, but we add an independent part named `Task`
   ![image](https://user-images.githubusercontent.com/15820530/147432424-d20b940a-6afa-4e7b-a5c3-d5720672b227.png)
   
   So in this situation, I think we should not revert doc `system-manual.md`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #609: [Bug-7389][docs-zh][docs] Fix System User Manual link failure in version 2.0.1 and version 2.0.0

Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #609:
URL: https://github.com/apache/dolphinscheduler-website/pull/609


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #609: [Bug-7389][docs-zh][docs] Fix System User Manual link failure in version 2.0.1 and version 2.0.0

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #609:
URL: https://github.com/apache/dolphinscheduler-website/pull/609#issuecomment-1002375307


   @uestczhuhao Are you still WIP?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #609: [Bug-7389][docs-zh][docs] Fix System User Manual link failure in version 2.0.1 and version 2.0.0

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #609:
URL: https://github.com/apache/dolphinscheduler-website/pull/609#discussion_r775326878



##########
File path: docs/en-us/2.0.0/user_doc/architecture/design.md
##########
@@ -78,7 +78,7 @@ scheduling system
 * **UI**
 
   The front-end page of the system provides various visual operation interfaces of the system,See more
-  at<a href="/en-us/docs/2.0.0/user_doc/system-manual.html" target="_self"> System User Manual </a>section。
+  at [System User Manual](../guide/system-manual.md) section。

Review comment:
       And for this dead link, maybe we better to change it to `../guide/homepage.md` and the content change to `Introduction to Functions`
   ![image](https://user-images.githubusercontent.com/15820530/147432618-9e789d8f-f9ab-4f96-8667-909d983d2d50.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #609: [Bug-7389][docs-zh][docs] Fix System User Manual link failure in version 2.0.1 and version 2.0.0

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #609:
URL: https://github.com/apache/dolphinscheduler-website/pull/609#discussion_r776594917



##########
File path: docs/zh-cn/2.0.1/user_doc/architecture/design.md
##########
@@ -68,7 +68,7 @@
 
 * **UI** 
 
-    系统的前端页面,提供系统的各种可视化操作界面,详见<a href="/zh-cn/docs/2.0.1/user_doc/system-manual.html" target="_self">系统使用手册</a>部分。
+    系统的前端页面,提供系统的各种可视化操作界面,详见[功能介绍](../guide/homepage.md)部分。

Review comment:
       I found it also in dev doc https://github.com/apache/dolphinscheduler-website/blob/d423ef4bf7b9a7a6f48cf5bab5d6a100d42122a1/docs/zh-cn/dev/user_doc/architecture/design.md#L102. could your also change `dev` zh and en doc? @uestczhuhao 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org