You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/09/23 19:32:15 UTC
Review Request 68818: Fixed accidental use-after-move.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68818/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Meng Zhu.
Repository: mesos
Description
-------
This code was incorrectly accessing an object after it was moved from.
This patch fixes the typo which lead to that behavior.
Diffs
-----
src/tests/resources_tests.cpp 002338a911051df8072c9753c69977841bbac3d1
Diff: https://reviews.apache.org/r/68818/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 68818: Fixed accidental use-after-move.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68818/#review208956
-----------------------------------------------------------
Ship it!
ah, thanks for catching this!
- Meng Zhu
On Sept. 23, 2018, 12:32 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68818/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2018, 12:32 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This code was incorrectly accessing an object after it was moved from.
> This patch fixes the typo which lead to that behavior.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp 002338a911051df8072c9753c69977841bbac3d1
>
>
> Diff: https://reviews.apache.org/r/68818/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68818: Fixed accidental use-after-move.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68818/#review208935
-----------------------------------------------------------
PASS: Mesos patch 68818 was successfully built and tested.
Reviews applied: `['68818']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2384/mesos-review-68818
- Mesos Reviewbot Windows
On Sept. 23, 2018, 7:32 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68818/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2018, 7:32 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This code was incorrectly accessing an object after it was moved from.
> This patch fixes the typo which lead to that behavior.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp 002338a911051df8072c9753c69977841bbac3d1
>
>
> Diff: https://reviews.apache.org/r/68818/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>