You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/11/29 08:36:56 UTC
[GitHub] [incubator-uniffle] xianjingfeng opened a new issue, #375: [Improvement]
xianjingfeng opened a new issue, #375:
URL: https://github.com/apache/incubator-uniffle/issues/375
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
HDFS_URI will be null if we run a single UT method.
https://github.com/apache/incubator-uniffle/blob/c503f8f8ee522f67551652c5821cc1a7feb92ef7/integration-test/common/src/test/java/org/apache/uniffle/test/ShuffleServerWithMemLocalHdfsTest.java#L59
Several other UTs have the same problem.
### How should we improve?
Assign value in `setupServers`
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1331587090
I think that there is no problem about grammar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1331563056
> > I can't reproduce it
>
> Not run `ShuffleServerWithMemLocalHdfsTest`. Try to run `ShuffleServerWithMemLocalHdfsTest.memoryLocalFileHDFSReadWithFilterTest` It only appears when execute a single method
This is the result that I run `ShuffleServerWithMemLocalHdfsTest.memoryLocalFileHDFSReadWithFilterTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1331570173
It seems that different IDE versions have different results.:thinking: Mine is IDEA 2022.2.3
Start command as follow
```shell
/usr/local/jdk18/bin/java -ea -ea -Xmx3g -Didea.test.cyclic.buffer.size=1048576 -javaagent:xxx/lib/idea_rt.jar=35244:xxx/idea-IU-222.4345.14/bin -Dfile.encoding=UTF-8 -classpath xxx.jar com.intellij.rt.junit.JUnitStarter -ideVersion5 -junit5 org.apache.uniffle.test.ShuffleServerWithMemLocalHdfsTest,memoryLocalFileHDFSReadWithFilterTest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1331575488
> Could the maven reproduce this problem?
```shell
mvn -Dtest=org.apache.uniffle.test.ShuffleServerWithMemLocalHdfsTest#memoryLocalFileHDFSReadWithFilterTest test
```
This is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] xianjingfeng closed issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
xianjingfeng closed issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
URL: https://github.com/apache/incubator-uniffle/issues/375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1330510621
I can't reproduce it
<img width="592" alt="企业微信截图_d2c7b81e-33b0-4067-ae64-ee6be96f5e39" src="https://user-images.githubusercontent.com/8159038/204522141-260d0ff8-bcdf-4544-9439-cc98387f8ff6.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1330285254
Could you give a way to reproduce the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1330422159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1331576426
So I think we should close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1331570851
Could the maven reproduce this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1331562009
> I can't reproduce it
Not run `ShuffleServerWithMemLocalHdfsTest`.
Try to run `ShuffleServerWithMemLocalHdfsTest.memoryLocalFileHDFSReadWithFilterTest`
It only appears when execute a single method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1331576204
> > Could the maven reproduce this problem?
>
> ```shell
> mvn -Dtest=org.apache.uniffle.test.ShuffleServerWithMemLocalHdfsTest#memoryLocalFileHDFSReadWithFilterTest test
> ```
>
> This is ok.
I guess this problem is related to IDEA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on issue #375: [Improvement] HDFS_URI will be null if we run a single UT method.
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on issue #375:
URL: https://github.com/apache/incubator-uniffle/issues/375#issuecomment-1331579559
I think we should consider if it is reasonable first. Whether `@BeforeAll` of parent class is always execure before the assignment of static variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org