You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/05/01 21:06:35 UTC
[PR] Vendor clipboard.js + remove HubSpot/OCI training widgets (refs #354) [grails-static-website]
jamesfredley opened a new pull request, #467:
URL: https://github.com/apache/grails-static-website/pull/467
## Summary
Three Content Security Policy violations on the rendered guide pages, all resolved. Refs #354.
## CSP violations addressed
| Source | Fix |
|---|---|
| `https://js.hsforms.net/forms/v2.js` (HubSpot consultation form embed) | Removed from `common-helpWithGrails.adoc`; replaced with Apache community channels. Also removed the unused `guidesuggestionform.html` partial that referenced the same script. |
| `https://cdnjs.cloudflare.com/ajax/libs/clipboard.js/1.7.1/clipboard.min.js` | Vendored to `guides/resources/js/clipboard.min.js` and switched the `layout.html` reference to the local path (`\/js/clipboard.min.js`). |
| `https://training.grails.org/training` (XHR to defunct OCI training catalog) | Removed from `common-training.adoc`; the endpoint was discontinued when the project was donated to the Apache Software Foundation. |
## Content rewrites
- `common-helpWithGrails.adoc`: was the OCI sponsorship + HubSpot consultation pitch. Now lists the Apache community channels: Slack, user mailing list, dev mailing list, GitHub issues.
- `common-training.adoc`: was the OCI training widget XHR. Now a short pointer to the Apache Grails Learning page until the community-maintained training catalog is restored.
- `GuidesPage.guideSuggestion()` method removed - it was unreachable (no callers) and only existed to embed the HubSpot suggestion form.
## Local verification
`./gradlew clean build buildAllGuides --no-daemon --no-configuration-cache` -> BUILD SUCCESSFUL.
Sampled 4 rendered files for `hsforms.net`, `cdnjs.cloudflare.com`, `training.grails.org`: zero hits in any of them. `clipboard.min.js` reference in guide pages now points at the local `../js/clipboard.min.js`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Vendor clipboard.js + remove HubSpot/OCI training widgets (refs #354) [grails-static-website]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley merged PR #467:
URL: https://github.com/apache/grails-static-website/pull/467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Vendor clipboard.js + remove HubSpot/OCI training widgets (refs #354) [grails-static-website]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #467:
URL: https://github.com/apache/grails-static-website/pull/467#discussion_r3175234526
##########
guides/common/common-helpWithGrails.adoc:
##########
@@ -1,21 +1,10 @@
-++++
-<h3 style="color: #333; margin-bottom:25px;"><a href="https://objectcomputing.com/" target="_blank">Object Computing, Inc.</a> (OCI) sponsored the creation of this Guide. A variety of consulting and support services are available.</h3>
+== Help with Apache Grails
-<!-- BEGIN HubSpot Consultation Form -->
+Apache Grails is supported by an active community of contributors and the Apache Software Foundation. If you need help working through a guide, want to discuss the framework, or have run into something that looks like a bug, the channels below are the right place to start.
-<!--[if lte IE 8]>
-<script charset="utf-8" type="text/javascript" src="//js.hsforms.net/forms/v2-legacy.js"></script>
-<![endif]-->
-<script charset="utf-8" type="text/javascript" src="//js.hsforms.net/forms/v2.js"></script>
-<script>
- hbspt.forms.create({
- portalId: "4547412",
- formId: "f8bc9b16-d5f6-4226-a24e-da0eb8b73363"
-});
-</script>
+* https://slack.grails.org[Slack] - real-time conversation with the Apache Grails community.
+* https://lists.apache.org/list.html?dev@grails.apache.org[Developer mailing list] - design discussions and contributor coordination.
+* https://lists.apache.org/list.html?users@grails.apache.org[Users mailing list] - end-user questions and answers.
+* https://github.com/apache/grails-core/issues[Issue tracker on GitHub] - file a bug or feature request against the framework.
-<!-- END HubSpot Consultation Form -->
-
-<h3 style="color: #333;">OCI is Home to Grails</h3>
-
-<p><a href="https://objectcomputing.com/products/2gm-team" target="_blank">Meet the Team</a></p>
+For Grails plugins, see the matching project on https://github.com/apache?q=grails[the apache org] or the plugin's own GitHub repository.
Review Comment:
Capitalization: link text should use the proper noun “Apache” (not “apache”).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Vendor clipboard.js + remove HubSpot/OCI training widgets (refs #354) [grails-static-website]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #467:
URL: https://github.com/apache/grails-static-website/pull/467#issuecomment-4361663164
<!-- Bito Reply -->
Yes, 'Apache' should be capitalized as a proper noun in the link text. The current text 'the apache org' in the AsciiDoc link should be updated to 'the Apache org' for correctness.
**guides/common/common-helpWithGrails.adoc**
```
For Grails plugins, see the matching project on https://github.com/apache?q=grails[the Apache org] or the plugin's own GitHub repository.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org