[GitHub] [hive] zabetak commented on a diff in pull request #4253: HIVE-27278: Simplify correlated queries with empty inputs

["zabetak (via GitHub)" <gi...@apache.org>]

zabetak commented on code in PR #4253:
URL: https://github.com/apache/hive/pull/4253#discussion_r1176298845


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRemoveEmptySingleRules.java:
##########
@@ -192,6 +178,79 @@ public interface JoinRightEmptyRuleConfig extends PruneEmptyRule.Config {
     }
   }
 
+  private static RelNode padWithNulls(RelBuilder builder, RelNode input, RelDataType resultType,
+      boolean leftPadding) {

Review Comment:
   This will lead to duplicating some code that I would like to avoid hence this refactoring.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org