You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Daniel L. Rall" <dl...@finemaltcoding.com> on 2004/03/15 19:26:39 UTC
[Java][PATCH] Build system changes and test seed code for SWIG/Java
Any comments?
------------
Integrated more of the SWIG/Java build into the gen_make.py system,
and added test code. Added automation to the gen_make.py system to
JAR up .class files.
* Makefile.in
(SWIG_EXTRA_JAVA_DIR, SWIG_EXTRA_SWIG_DIR, SWIG_JAVA_SOURCES):
Removed, obviated by configuration in build.conf.
(swig-java-setup): New target derived from code from the
INSTALL_EXTRA_SWIG_JAVA macro.
(INSTALL_EXTRA_SWIG_JAVA): Reduced to only true installation
operations. Compilation and JAR'ing are now handled by the
gen_make.py system.
(check-swig-java): New target for running the SWIG/Java regression
tests.
* build.conf
(swig-java-api): New target for building the implementation-agnostic
SVN Java API. Currently coupled to the SWIG/Java implementation
targets, this will either be decoupled or merged in the future.
(swig-java-java): New target for building the SWIG-dependent Java
code.
(swig-java-tests): New target for building the SWIG-dependent Java
testing code.
(javahl-java, javahl-tests): Added "package-roots" config parameter
for correct dependency list generation and JAR'ing of .class
files.
* build/generator/gen_base.py
(TargetJava.__init__): Added new "packages" and "jar" instance
members, respectively set by the "package-roots" and "jar" config
params.
(TargetJava.add_dependencies): As .class files are likely not
generated into the same directory as the source files, the object
path may need adjustment. To this effect, take "target_ob.classes"
into account. This fixes a problem with the generation of the
path to the .class files, used in places like "javahl_java_DEPS"
in build-outputs.mk. The algorithm I used could misinterpret the
path information, but is "good enough" for the code we have to
date.
(TargetJavaClasses.add_dependencies): Use os.sep. Latent bug?
* build/generator/gen_make.py
(Generator.write): Use the "classes" rather than "path" field for
TargetJava generation (I'm worried this could break something),
working around an assertion failure triggered by
TargetJava.add_dependencies()'s adjustment of the path to .class
files.
Added a TODO for passing -g to javac when --enable-maintainer-mode
is in effect.
Broke long line.
When a TargetJava instance has its "jar" member set, automate
JAR'ing of .class files (only lightly tested). I didn't turn this
on for javahl.
* subversion/bindings/swig/java/org/tigris/subversion/test/SVNTests.java
* subversion/bindings/swig/java/org/tigris/subversion/test/BasicTests.java
Used modified copies of JavaHL's test cases as starting points for
SWIG/Java testing.
Re: [Java][PATCH] Build system changes and test seed code for SWIG/Java
Posted by Patrick Mayweg <ma...@qint.de>.
Hi Daniel,
Daniel L. Rall wrote:
> Daniel L. Rall wrote:
>
>> Justin Erenkrantz wrote:
>>
>>> --On Monday, March 15, 2004 11:26 AM -0800 "Daniel L. Rall"
>>> <dl...@finemaltcoding.com> wrote:
>>>
>>>> Integrated more of the SWIG/Java build into the gen_make.py system,
>>>> and added test code. Added automation to the gen_make.py system to
>>>> JAR up .class files.
>>>
>>>
>>>
>>>
>>> Looks good upon inspection. I'll try to build it here on Mac OS X
>>> later in the week. I'd say that you should commit this now as
>>> what's there now for SWIG/Java is pretty sad. ;-)
>>>
>>> Thanks! -- justin
>>
>>
>>
>> Thanks, committed as r9080 with some necessary changes.
>
>
> By the way, I the javahl test cases that I used as a base for the
> SWIG/Java test cases look like they're built using a different version
> of JUnit than what I've got (which is 3.7). I couldn't even compile
> them. What version of JUnit are they written against?
>
The current 3.8.1 version. They look if they were released in September
2002.
Patrick
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Java][PATCH] Build system changes and test seed code for
SWIG/Java
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Tuesday, March 16, 2004 9:38 AM -0800 "Daniel L. Rall"
<dl...@finemaltcoding.com> wrote:
> By the way, I the javahl test cases that I used as a base for the SWIG/Java
> test cases look like they're built using a different version of JUnit than
> what I've got (which is 3.7). I couldn't even compile them. What version
> of JUnit are they written against?
No idea, but I used the latest version of junit (3.8.1) and it compiled/ran
fine for me. -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Java][PATCH] Build system changes and test seed code for SWIG/Java
Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.
Daniel L. Rall wrote:
> Justin Erenkrantz wrote:
>
>> --On Monday, March 15, 2004 11:26 AM -0800 "Daniel L. Rall"
>> <dl...@finemaltcoding.com> wrote:
>>
>>> Integrated more of the SWIG/Java build into the gen_make.py system,
>>> and added test code. Added automation to the gen_make.py system to
>>> JAR up .class files.
>>
>>
>>
>> Looks good upon inspection. I'll try to build it here on Mac OS X
>> later in the week. I'd say that you should commit this now as what's
>> there now for SWIG/Java is pretty sad. ;-)
>>
>> Thanks! -- justin
>
>
> Thanks, committed as r9080 with some necessary changes.
By the way, I the javahl test cases that I used as a base for the SWIG/Java
test cases look like they're built using a different version of JUnit than
what I've got (which is 3.7). I couldn't even compile them. What version of
JUnit are they written against?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Java][PATCH] Build system changes and test seed code for SWIG/Java
Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.
Justin Erenkrantz wrote:
> --On Monday, March 15, 2004 11:26 AM -0800 "Daniel L. Rall"
> <dl...@finemaltcoding.com> wrote:
>
>> Integrated more of the SWIG/Java build into the gen_make.py system,
>> and added test code. Added automation to the gen_make.py system to
>> JAR up .class files.
>
>
> Looks good upon inspection. I'll try to build it here on Mac OS X later
> in the week. I'd say that you should commit this now as what's there
> now for SWIG/Java is pretty sad. ;-)
>
> Thanks! -- justin
Thanks, committed as r9080 with some necessary changes.
- Dan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Java][PATCH] Build system changes and test seed code for
SWIG/Java
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Monday, March 15, 2004 11:26 AM -0800 "Daniel L. Rall"
<dl...@finemaltcoding.com> wrote:
> Integrated more of the SWIG/Java build into the gen_make.py system,
> and added test code. Added automation to the gen_make.py system to
> JAR up .class files.
Looks good upon inspection. I'll try to build it here on Mac OS X later in
the week. I'd say that you should commit this now as what's there now for
SWIG/Java is pretty sad. ;-)
Thanks! -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org