You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Chun-Hung Hsiao (JIRA)" <ji...@apache.org> on 2018/06/01 01:41:00 UTC
[jira] [Comment Edited] (MESOS-8943) Add metrics about CSI calls.
[ https://issues.apache.org/jira/browse/MESOS-8943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497460#comment-16497460 ]
Chun-Hung Hsiao edited comment on MESOS-8943 at 6/1/18 1:40 AM:
----------------------------------------------------------------
{noformat}
commit cae7d7a385e9edf0db81d524c6a208f6ad8540fd
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Tue May 29 19:29:16 2018 -0700
Added the `RPC` enum and `RPCTraits` helper.
To make it easy to enumerate all types of CSI RPC calls, the `RPC` enum
is introduced. The `RPCTraits` helper class can be used to determine the
request and response type of a particular RPC.
Review: https://reviews.apache.org/r/67375{noformat}
{noformat}
commit 15fc86d22f1fbe922ef878bb2e6f6462d2248b14
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Tue May 22 17:34:06 2018 -0700
Added per-CSI-call RPC metrics for SLRP.
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/cancelled`
To add these per-CSI-call metrics, each method in `csi::v0::Client`,
e.g., `csi::v0::Client::Probe`, is changed to
`csi::v0::Client::call<PROBE>`, to make RPC calls based on the RPC enum
value. A `call` helper function in SLRP is also added to intercept CSI
calls and update the corresponding metrics.
Review: https://reviews.apache.org/r/67255{noformat}
{noformat}
commit 1a1f0bab2fde34095c643cefdb24d700441048d0
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Tue May 22 14:47:03 2018 -0700
Added a unit test for CSI plugin RPC metrics.
This patch adds the `ROOT_CsiPluginRpcMetrics` test that issues a
`CREATE_VOLUME` followed by a `DESTROY_VOLUME`, which would fail due to
an out-of-band deletion of the actual volume.
Review: https://reviews.apache.org/r/67256{noformat}
{noformat}
commit db075fc67aceb8f75bbc204aae042a30b65c57e3
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Thu May 24 18:01:26 2018 -0700
Added documentation for resource provider and CSI plugin metrics.
Review: https://reviews.apache.org/r/67303{noformat}
was (Author: chhsia0):
{noformat}
commit cae7d7a385e9edf0db81d524c6a208f6ad8540fd
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Tue May 29 19:29:16 2018 -0700
Added the `RPC` enum and `RPCTraits` helper.
To make it easy to enumerate all types of CSI RPC calls, the `RPC` enum
is introduced. The `RPCTraits` helper class can be used to determine the
request and response type of a particular RPC.
Review: https://reviews.apache.org/r/67375{noformat}
{noformat}
commit 15fc86d22f1fbe922ef878bb2e6f6462d2248b14
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Tue May 22 17:34:06 2018 -0700
Added per-CSI-call RPC metrics for SLRP.
For each CSI call, e.g., `csi.v0.Identity.Probe`, we the following
metrics for SLRP:
`csi_plugin/rpcs/csi.v0.Identity.Probe/pending`
`csi_plugin/rpcs/csi.v0.Identity.Probe/successes`
`csi_plugin/rpcs/csi.v0.Identity.Probe/errors`
`csi_plugin/rpcs/csi.v0.Identity.Probe/cancelled`
To add these per-CSI-call metrics, each method in `csi::v0::Client`,
e.g., `csi::v0::Client::Probe`, is changed to
`csi::v0::Client::call<PROBE>`, to make RPC calls based on the RPC enum
value. A `call` helper function in SLRP is also added to intercept CSI
calls and update the corresponding metrics.
Review: https://reviews.apache.org/r/67255{noformat}
{noformat}
commit 1a1f0bab2fde34095c643cefdb24d700441048d0
Author: Chun-Hung Hsiao <ch...@mesosphere.io>
Date: Tue May 22 14:47:03 2018 -0700
Added a unit test for CSI plugin RPC metrics.
This patch adds the `ROOT_CsiPluginRpcMetrics` test that issues a
`CREATE_VOLUME` followed by a `DESTROY_VOLUME`, which would fail due to
an out-of-band deletion of the actual volume.
Review: https://reviews.apache.org/r/67256{noformat}
> Add metrics about CSI calls.
> ----------------------------
>
> Key: MESOS-8943
> URL: https://issues.apache.org/jira/browse/MESOS-8943
> Project: Mesos
> Issue Type: Task
> Components: storage
> Reporter: Chun-Hung Hsiao
> Assignee: Chun-Hung Hsiao
> Priority: Major
> Labels: mesosphere, storage
> Fix For: 1.7.0
>
>
> We should add metrics for CSI calls so operators can be alerted on flapping CSI plugins.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)