You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2023/01/11 08:09:31 UTC

[GitHub] [activemq] michaelandrepearce commented on a diff in pull request #953: [AMQ-8354] Add helper methods needed for replica plugin.

michaelandrepearce commented on code in PR #953:
URL: https://github.com/apache/activemq/pull/953#discussion_r1066683378


##########
activemq-broker/src/main/java/org/apache/activemq/broker/scheduler/SchedulerBroker.java:
##########
@@ -54,7 +54,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class SchedulerBroker extends BrokerFilter implements JobListener {
+public class SchedulerBroker extends MutableBrokerFilter implements JobListener {

Review Comment:
   Wont this be overhead now for use cases not needing this? due to the sync in mutable thats needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org