[GitHub] [druid] clintropolis commented on a change in pull request #9516: More efficient join filter rewrites

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #9516: More efficient join filter rewrites
URL: https://github.com/apache/druid/pull/9516#discussion_r393260622
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/segment/join/JoinFilterAnalyzerTest.java
 ##########
 @@ -245,6 +266,27 @@ public void test_filterPushDown_factToRegionToCountryLeftFilterOnNullColumns()
         )
     );
 
+    List<JoinableClause> joinableClauses = ImmutableList.of(
+        factToRegion(JoinType.LEFT),
+        regionToCountry(JoinType.LEFT)
+    );
+
+    JoinFilterPreAnalysis joinFilterPreAnalysis = JoinFilterAnalyzer.computeJoinFilterPreAnalysis(
 
 Review comment:
   could you make a utility method that makes a `JoinFilterPreAnalysis` from a `joinableClauses` and `originalFilter`? seems like a lot of these blocks and all the other arguments are the same. Alternatively a builder for `JoinFilterPreAnalysis` would work, though idk if worth the effort since it would be mostly used by tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org