You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "yangyulely (via GitHub)" <gi...@apache.org> on 2025/08/28 04:57:14 UTC

[PR] Close db connection using context manager in mysql hook [airflow]

yangyulely opened a new pull request, #55008:
URL: https://github.com/apache/airflow/pull/55008

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   ## Why
   
   - The `bulk_load`, `bulk_dump`, and `bulk_load_custom` methods share common code for establishing connections, creating cursors, committing transactions, and closing connections. This can be extracted into a reusable context manager.
   - The `bulk_load` and `bulk_dump` methods do not explicitly close the database cursor. Using a context manager will ensure that both the connection and cursor are always closed properly, even if errors occur.
   - Encapsulating the connection and cursor logic within a context manager will make the bulk operation methods cleaner and easier to understand.
   
   ## How
   __1. Introduce a Context Manager for Connection and Cursor Handling__
   A new private method, `_get_cursor`, will be added to manage the lifecycle of database connections and cursors. 
   
   __2. Refactor Bulk Operation Methods__
   The methods `bulk_load`, `bulk_dump`, and `bulk_load_custom` will be updated to use the new `_get_cursor` context manager. This will remove duplicated code for connection, cursor creation, committing, and closing, making the methods cleaner and more robust.
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Close db connection using context manager in mysql hook [airflow]

Posted by "sjyangkevin (via GitHub)" <gi...@apache.org>.
sjyangkevin commented on code in PR #55008:
URL: https://github.com/apache/airflow/pull/55008#discussion_r2309124885


##########
providers/mysql/src/airflow/providers/mysql/hooks/mysql.py:
##########


Review Comment:
   thanks for the proposal, and the proposed changes sounds reasonable, but comes with the following trade-offs.
   
   In the current implementation, the connection seems like a property. If it doesn't exist, a new connection will be created `self.get_connection(self.get_conn_id())`. Otherwise, the existing one `self.connection` will be reused.
   ```
   conn = self.connection or self.get_connection(self.get_conn_id())
   ```
   By making it a context manager, looks like the connection **is opened and closed every time** when an operation is executed, like `bulk_load` or `bulk_dump`. So, you might not be able to reuse the same connection for several operations.
   
   Also, wondering if it is compatible with the "autocommit".
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Close db connection using context manager in mysql hook [airflow]

Posted by "yangyulely (via GitHub)" <gi...@apache.org>.
yangyulely commented on code in PR #55008:
URL: https://github.com/apache/airflow/pull/55008#discussion_r2309551248


##########
providers/mysql/src/airflow/providers/mysql/hooks/mysql.py:
##########


Review Comment:
   Thanks for your review, I'll check it later again.
   I am confused how connection was reused in the original code. Since I notice the `conn.close()` is called to close the connection in the `bulk_load` and `bulk_dump` methods.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Close db connection using context manager in mysql hook [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #55008:
URL: https://github.com/apache/airflow/pull/55008#issuecomment-3399482923

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Close db connection using context manager in mysql hook [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #55008: Close db connection using context manager in mysql hook
URL: https://github.com/apache/airflow/pull/55008


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Close db connection using context manager in mysql hook [airflow]

Posted by "sjyangkevin (via GitHub)" <gi...@apache.org>.
sjyangkevin commented on code in PR #55008:
URL: https://github.com/apache/airflow/pull/55008#discussion_r2310173626


##########
providers/mysql/src/airflow/providers/mysql/hooks/mysql.py:
##########


Review Comment:
   Yeah, maybe the intention for `bulk_load` and `bulk_dump` is for one time execution. The following code is in the parent class. I think it is how the connection is being cached. hope it help.
   
   https://github.com/apache/airflow/blob/b4266ead1cef5f11f74f365f0eff5144a17f2e20/providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py#L240-L244



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org