You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/06 00:54:11 UTC
[GitHub] [kafka] showuon opened a new pull request #10635: KAFKA-9295: increase start stream timeout
showuon opened a new pull request #10635:
URL: https://github.com/apache/kafka/pull/10635
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10635: KAFKA-9295: increase start stream timeout
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10635:
URL: https://github.com/apache/kafka/pull/10635#issuecomment-833225272
Merged to trunk -- let's hope these good results continue. I'm going to close the ticket again so people are more likely to report it if they see things to continue to break.
Merged about 9:58pm PST on May 5th, so please disregard any test failures on builds kicked off prior to that time (and raise any new failures by reopening the ticket)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10635: KAFKA-9295: increase start stream timeout
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10635:
URL: https://github.com/apache/kafka/pull/10635#issuecomment-833149684
Just ping me when the build passes, you know the drill 🙂
By the way, even if it does fail at another point later on in this test, I'd like to go ahead and merge this anyways. Hopefully increasing the timeout will at least reduce the number of failures, of which there have been quite a few, and will make it easier to investigate the remaining problems. But let me know if you'd prefer that I wait in case that does happen. Though I'm feeling optimistic it won't 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10635: KAFKA-9295: increase start stream timeout
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10635:
URL: https://github.com/apache/kafka/pull/10635#issuecomment-833148107
@ableegoldman , please take a look. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10635: KAFKA-9295: increase start stream timeout
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10635:
URL: https://github.com/apache/kafka/pull/10635#issuecomment-833152754
This should be merged soon, and I'm confident increasing the timeout will reduce the number of failure a lot. 🤞 Let's wait for the jenkins build. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #10635: KAFKA-9295: increase start stream timeout
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10635:
URL: https://github.com/apache/kafka/pull/10635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10635: KAFKA-9295: increase start stream timeout
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10635:
URL: https://github.com/apache/kafka/pull/10635#issuecomment-833204958
@ableegoldman , the failed tests are all flaky. (3 `RaftClusterTest`, and 1 `testMetricsDuringTopicCreateDelete` traced in KAFKA-9009). And most importantly, no failed `shouldInnerJoinMultiPartitionQueryable` test!
```
Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()
Build / JDK 11 and Scala 2.13 / kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete()
Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org