You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "AndriiTsepukh (via GitHub)" <gi...@apache.org> on 2026/09/29 15:51:32 UTC
[PR] [incubator-kie#7144] fix(drools): keep `contains` on a generic `Map.get()` String matching after jitting [incubator-kie]
AndriiTsepukh opened a new pull request, #7145:
URL: https://github.com/apache/incubator-kie/pull/7145
PatternBuilder resolves Map<K, String>.get(...) to String from the generics, so the build accepts `contains` on it. The interpreted MVEL evaluator then does a substring check on the runtime String. Once the constraint is jitted, ASMConditionEvaluatorJitter sees the erased Object type and emits EvaluatorHelper.contains(Object, Object), which handled only collections and arrays and returned false for a String. The rule matched for the first drools.jittingThreshold evaluations and stopped matching after that.
EvaluatorHelper.contains(Object, Object) now does the same String check as ParseTools.containsCheck, so the jitted and interpreted evaluators agree.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
**Thank you for submitting this pull request**
**NOTE!:** Double-check the target branch for this PR.
The default is `main`.
**Ports** If a forward-port or a backport is needed, paste the forward port PR here
* [link](https://www.example.com)
**Issue**: _(please edit the GitHub Issues link if it exists)_
* [link](https://www.example.com)
**Referenced Pull Requests**: _(please edit the URLs of referenced pull requests if they exist)_
* paste the link(s) from GitHub here
* link 2
* link 3 etc.
<details>
<summary>
How to replicate the CI locally
</summary>
The CI does "simple" maven build(s). All commands can be run from the repository root.
**Quick build of just your changed modules and their dependents** (mirrors what CI does on a PR):
```shell
# 1. Build upstream dependencies of your changes (skip tests for speed)
mvn -T 1C --batch-mode -fae -DskipTests -DskipITs \
-Denforcer.skip=true -Dcheckstyle.skip=true -Dformatter.skip=true -Darchunit.skip=true \
-pl <upstream-modules> install
# 2. Build your changed modules and their transitive dependents (with tests)
mvn --batch-mode -fae -Dreproducible \
-pl <affected-modules> install
```
To compute `<upstream-modules>` and `<affected-modules>` automatically (requires [JBang](https://www.jbang.dev/)):
```shell
jbang script/ci/CiComputeBuildScopes.java \
<changed-files.txt> \
<upstream-modules.txt> \
<affected-modules.txt> \
<changed-modules.txt>
```
**Full build** (equivalent to what runs on every push to `main`):
```shell
mvn --batch-mode -fae -Dfull -Dreproducible install
```
`-Dfull` additionally builds the distribution modules and generates Javadoc JARs.
**Useful flags:**
| Flag | Effect |
|---|---|
| `-Dquickly` | Skip tests, Checkstyle, formatter, Enforcer, ArchUnit |
| `-DskipTests` | Skip unit tests |
| `-DskipITs` | Skip integration tests |
| `-Denforcer.skip=true` | Skip Enforcer plugin |
| `-Dcheckstyle.skip=true` | Skip Checkstyle |
| `-Dformatter.skip=true` | Skip formatter |
| `-Darchunit.skip=true` | Skip ArchUnit |
</details>
<details>
<summary>
How to retest this PR or trigger a specific build
</summary>
- To **re-run CI**: push a new commit to the PR (an empty commit is enough: `git commit --allow-empty -m "re-trigger CI"`).
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie#7144] fix(drools): keep `contains` on a generic `Map.get()` String matching after jitting [incubator-kie]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer merged PR #7145:
URL: https://github.com/apache/incubator-kie/pull/7145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie#7144] fix(drools): keep `contains` on a generic `Map.get()` String matching after jitting [incubator-kie]
Posted by "yesamer (via GitHub)" <gi...@apache.org>.
yesamer commented on PR #7145:
URL: https://github.com/apache/incubator-kie/pull/7145#issuecomment-5906994112
@AndriiTsepukh Thank you for your contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org