You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/02/07 16:05:32 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4260: Codecov

ocket8888 commented on a change in pull request #4260: Codecov
URL: https://github.com/apache/trafficcontrol/pull/4260#discussion_r376472178
 
 

 ##########
 File path: tools/golang/docker-compose.yml
 ##########
 @@ -32,4 +32,4 @@ services:
       dockerfile: tools/golang/Dockerfile
       target: unit
     volumes:
-      - ../..:/go/src/github.com/apache/trafficcontrol
 
 Review comment:
   Couple reasons
   
   1. Because the Dockerfile is already `ADD`ing the whole context to that path.
   2. Using that volume meant that some of the temporary files being created were being output into the source directory owned by `root:root` with permissions `-rw-------` and in general if we did things like `go fmt` it'd modify the actual source when ran. Seemed dangerous.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services