You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "XiaoYou201 (via GitHub)" <gi...@apache.org> on 2024/05/08 06:54:41 UTC
[PR] [Inlong-10144][Sort] Redis connectors support audit ID [inlong]
XiaoYou201 opened a new pull request, #10146:
URL: https://github.com/apache/inlong/pull/10146
### Prepare a Pull Request
- [INLONG-10144][Sort] Redis connectors support audit ID
- Fixes #10144
### Motivation
Redis connector not support audit function. So this pr will make it support audit function.
### Modifications
Modify redis connector source.when source receive data, it will send audit information at same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10144][Sort] Redis connectors support audit ID [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #10146:
URL: https://github.com/apache/inlong/pull/10146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10144][Sort] Redis connectors support audit ID [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #10146:
URL: https://github.com/apache/inlong/pull/10146#discussion_r1593489726
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/source/RedisRowDataLookupFunction.java:
##########
@@ -107,6 +120,10 @@ public void eval(Object... keys) {
throw new UnsupportedOperationException(
String.format("Unsupported for redisCommand: %s", redisCommand));
}
+ if (sourceMetricData != null) {
+ sourceMetricData.outputMetricsWithEstimate(rowData, System.currentTimeMillis());
Review Comment:
no need to get current time here
see
private long getCurrentOrProvidedTime(long dataTime) {
return dataTime == 0 ? System.currentTimeMillis() : dataTime;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10144][Sort] Redis connectors support audit ID [inlong]
Posted by "XiaoYou201 (via GitHub)" <gi...@apache.org>.
XiaoYou201 commented on code in PR #10146:
URL: https://github.com/apache/inlong/pull/10146#discussion_r1593560456
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/source/RedisDynamicTableSource.java:
##########
@@ -37,7 +37,11 @@
import java.util.Map;
-import static org.apache.flink.table.types.logical.LogicalTypeRoot.*;
+import static org.apache.flink.table.types.logical.LogicalTypeRoot.BIGINT;
+import static org.apache.flink.table.types.logical.LogicalTypeRoot.DOUBLE;
Review Comment:
for format check，it not allow to import org.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10144][Sort] Redis connectors support audit ID [inlong]
Posted by "XiaoYou201 (via GitHub)" <gi...@apache.org>.
XiaoYou201 commented on code in PR #10146:
URL: https://github.com/apache/inlong/pull/10146#discussion_r1593521172
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/source/RedisRowDataLookupFunction.java:
##########
@@ -107,6 +120,10 @@ public void eval(Object... keys) {
throw new UnsupportedOperationException(
String.format("Unsupported for redisCommand: %s", redisCommand));
}
+ if (sourceMetricData != null) {
+ sourceMetricData.outputMetricsWithEstimate(rowData, System.currentTimeMillis());
Review Comment:
fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10144][Sort] Redis connectors support audit ID [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #10146:
URL: https://github.com/apache/inlong/pull/10146#discussion_r1593536876
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/source/RedisDynamicTableSource.java:
##########
@@ -37,7 +37,11 @@
import java.util.Map;
-import static org.apache.flink.table.types.logical.LogicalTypeRoot.*;
+import static org.apache.flink.table.types.logical.LogicalTypeRoot.BIGINT;
+import static org.apache.flink.table.types.logical.LogicalTypeRoot.DOUBLE;
Review Comment:
what are these code for ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10144][Sort] Redis connectors support audit ID [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #10146:
URL: https://github.com/apache/inlong/pull/10146#discussion_r1593490742
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/source/RedisRowDataLookupFunction.java:
##########
@@ -107,6 +120,10 @@ public void eval(Object... keys) {
throw new UnsupportedOperationException(
String.format("Unsupported for redisCommand: %s", redisCommand));
}
+ if (sourceMetricData != null) {
+ sourceMetricData.outputMetricsWithEstimate(rowData, System.currentTimeMillis());
+ }
+ LOG.info("Report audit: {} and time : {}", rowData, System.currentTimeMillis());
Review Comment:
log info is too much here since every data means a log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10144][Sort] Redis connectors support audit ID [inlong]
Posted by "XiaoYou201 (via GitHub)" <gi...@apache.org>.
XiaoYou201 commented on code in PR #10146:
URL: https://github.com/apache/inlong/pull/10146#discussion_r1593522589
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/source/RedisRowDataLookupFunction.java:
##########
@@ -107,6 +120,10 @@ public void eval(Object... keys) {
throw new UnsupportedOperationException(
String.format("Unsupported for redisCommand: %s", redisCommand));
}
+ if (sourceMetricData != null) {
+ sourceMetricData.outputMetricsWithEstimate(rowData, System.currentTimeMillis());
+ }
+ LOG.info("Report audit: {} and time : {}", rowData, System.currentTimeMillis());
Review Comment:
This log only use by test case to verify the audit result, I remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10144][Sort] Redis connectors support audit ID [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #10146:
URL: https://github.com/apache/inlong/pull/10146#discussion_r1593710242
##########
inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/source/RedisDynamicTableSource.java:
##########
@@ -37,7 +37,11 @@
import java.util.Map;
-import static org.apache.flink.table.types.logical.LogicalTypeRoot.*;
+import static org.apache.flink.table.types.logical.LogicalTypeRoot.BIGINT;
Review Comment:
not fixed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org