[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #3160: Seatunnel logo print

[GitBox <gi...@apache.org>]

hailin0 commented on code in PR #3160:
URL: https://github.com/apache/incubator-seatunnel/pull/3160#discussion_r1002466561


##########
seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/core/base/command/BaseTaskExecuteCommand.java:
##########
@@ -96,7 +95,8 @@ protected final void close(List<? extends Plugin<E>>... plugins) {
     protected void showAsciiLogo() {
         String printAsciiLogo = System.getenv("SEATUNNEL_PRINT_ASCII_LOGO");
         if ("true".equalsIgnoreCase(printAsciiLogo)) {
-            AsciiArtUtils.printAsciiArt(Constants.LOGO);

Review Comment:
   Remove unused code?
   
   https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/core/base/utils/AsciiArtUtils.java
   https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/AsciiArtUtils.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org