You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Shay Tsadok (JIRA)" <ji...@apache.org> on 2009/09/01 18:34:32 UTC
[jira] Created: (WINK-160) Consider content-type additional params
in the resouce matching process
Consider content-type additional params in the resouce matching process
-----------------------------------------------------------------------
Key: WINK-160
URL: https://issues.apache.org/jira/browse/WINK-160
Project: Wink
Issue Type: New Feature
Components: Server
Reporter: Shay Tsadok
Following our discussion in the mailing-list (http://n2.nabble.com/POSTing-collection-of-entities-td3560945.html#a3560945)
We should be able to consider the content-type params in the resource matching process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WINK-160) Consider content-type additional params
in the resouce matching process
Posted by "Shay Tsadok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shay Tsadok closed WINK-160.
----------------------------
I've verified the build and it looks great.
Thank you very much!!
> Consider content-type additional params in the resouce matching process
> -----------------------------------------------------------------------
>
> Key: WINK-160
> URL: https://issues.apache.org/jira/browse/WINK-160
> Project: Wink
> Issue Type: New Feature
> Components: Server
> Reporter: Shay Tsadok
> Assignee: Bryant Luk
> Fix For: 0.2
>
> Attachments: WINK-160.patch
>
>
> Following our discussion in the mailing-list (http://n2.nabble.com/POSTing-collection-of-entities-td3560945.html#a3560945)
> We should be able to consider the content-type params in the resource matching process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-160) Consider content-type additional
params in the resouce matching process
Posted by "Shay Tsadok (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750314#action_12750314 ]
Shay Tsadok commented on WINK-160:
----------------------------------
Sounds to me like a good solution.
There are some edge cases, for example:
{code}
@Consumes("application/xml;param2=value2")
public Response postEntity(Entity e) {
}
@Consumes("application/xml;type=collection")
public Response postEntities(EntitiesCollection e) {
}
{code}
What happens if we send application/xml;type=collection;param2=value2?
IMO, we shouldn't define the behavior of those cases now, we can simple set some limitations in which support the "simple cases".
> Consider content-type additional params in the resouce matching process
> -----------------------------------------------------------------------
>
> Key: WINK-160
> URL: https://issues.apache.org/jira/browse/WINK-160
> Project: Wink
> Issue Type: New Feature
> Components: Server
> Reporter: Shay Tsadok
> Attachments: WINK-160.patch
>
>
> Following our discussion in the mailing-list (http://n2.nabble.com/POSTing-collection-of-entities-td3560945.html#a3560945)
> We should be able to consider the content-type params in the resource matching process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WINK-160) Consider content-type additional params
in the resouce matching process
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk resolved WINK-160.
-----------------------------
Resolution: Fixed
Fix Version/s: 0.2
Assignee: Bryant Luk
> Consider content-type additional params in the resouce matching process
> -----------------------------------------------------------------------
>
> Key: WINK-160
> URL: https://issues.apache.org/jira/browse/WINK-160
> Project: Wink
> Issue Type: New Feature
> Components: Server
> Reporter: Shay Tsadok
> Assignee: Bryant Luk
> Fix For: 0.2
>
> Attachments: WINK-160.patch
>
>
> Following our discussion in the mailing-list (http://n2.nabble.com/POSTing-collection-of-entities-td3560945.html#a3560945)
> We should be able to consider the content-type params in the resource matching process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-160) Consider content-type additional params
in the resouce matching process
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk updated WINK-160:
----------------------------
Attachment: WINK-160.patch
A possible patch.
I'm assuming that the following is what is intended:
application/xml - postEntity
application/xml;type=collection - postEntities
application/xml;unknownparam=value - postEntity
application/xml;type=somethingelse = postEntity
application/xml;type=collection;param2=value2 - postEntities
{code}
@Consumes("application/xml")
public Response postEntity(Entity e) {
}
@Consumes("application/xml;type=collection")
public Response postEntities(EntitiesCollection e) {
}
{code}
> Consider content-type additional params in the resouce matching process
> -----------------------------------------------------------------------
>
> Key: WINK-160
> URL: https://issues.apache.org/jira/browse/WINK-160
> Project: Wink
> Issue Type: New Feature
> Components: Server
> Reporter: Shay Tsadok
> Attachments: WINK-160.patch
>
>
> Following our discussion in the mailing-list (http://n2.nabble.com/POSTing-collection-of-entities-td3560945.html#a3560945)
> We should be able to consider the content-type params in the resource matching process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-160) Consider content-type additional
params in the resouce matching process
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750516#action_12750516 ]
Hudson commented on WINK-160:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #129 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/129/])
Add support for differing @Consumes based on param
See []
> Consider content-type additional params in the resouce matching process
> -----------------------------------------------------------------------
>
> Key: WINK-160
> URL: https://issues.apache.org/jira/browse/WINK-160
> Project: Wink
> Issue Type: New Feature
> Components: Server
> Reporter: Shay Tsadok
> Attachments: WINK-160.patch
>
>
> Following our discussion in the mailing-list (http://n2.nabble.com/POSTing-collection-of-entities-td3560945.html#a3560945)
> We should be able to consider the content-type params in the resource matching process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-160) Consider content-type additional
params in the resouce matching process
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750456#action_12750456 ]
Bryant Luk commented on WINK-160:
---------------------------------
The behavior right now is undefined in which one it chooses in the case mentioned. Another case which winds up with the undefined behavior is if you only sent in application/xml with only those two last methods defined.
I'll go ahead and apply the patch later today.
> Consider content-type additional params in the resouce matching process
> -----------------------------------------------------------------------
>
> Key: WINK-160
> URL: https://issues.apache.org/jira/browse/WINK-160
> Project: Wink
> Issue Type: New Feature
> Components: Server
> Reporter: Shay Tsadok
> Attachments: WINK-160.patch
>
>
> Following our discussion in the mailing-list (http://n2.nabble.com/POSTing-collection-of-entities-td3560945.html#a3560945)
> We should be able to consider the content-type params in the resource matching process.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.