You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "henningn (via GitHub)" <gi...@apache.org> on 2023/12/19 19:59:42 UTC
[PR] fix(lazy-sheet): execute actions [myfaces-tobago]
henningn opened a new pull request, #4747:
URL: https://github.com/apache/myfaces-tobago/pull/4747
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(lazy-sheet): execute actions [myfaces-tobago]
Posted by "henningn (via GitHub)" <gi...@apache.org>.
henningn merged PR #4747:
URL: https://github.com/apache/myfaces-tobago/pull/4747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(lazy-sheet): execute actions [myfaces-tobago]
Posted by "henningn (via GitHub)" <gi...@apache.org>.
henningn commented on code in PR #4747:
URL: https://github.com/apache/myfaces-tobago/pull/4747#discussion_r1431901231
##########
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISheet.java:
##########
@@ -84,24 +84,17 @@ public abstract class AbstractUISheet extends AbstractUIData
private transient MeasureList columnLayout;
private transient boolean autoLayout;
private transient boolean lazyUpdate;
+ private transient int lazyFirstRow;
private transient Grid headerGrid;
@Override
public void encodeAll(FacesContext facesContext) throws IOException {
if (isLazy()) {
- if (getRows() == 0) {
- LOG.warn("Sheet id={} has lazy=true set, but not set the rows attribute!", getClientId(facesContext));
- }
- if (getShowRowRange() != ShowPosition.none) {
Review Comment:
We can keep the warnings for "lazy=true AND rows > 0". I will change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(lazy-sheet): execute actions [myfaces-tobago]
Posted by "bohmber (via GitHub)" <gi...@apache.org>.
bohmber commented on code in PR #4747:
URL: https://github.com/apache/myfaces-tobago/pull/4747#discussion_r1431888990
##########
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISheet.java:
##########
@@ -84,24 +84,17 @@ public abstract class AbstractUISheet extends AbstractUIData
private transient MeasureList columnLayout;
private transient boolean autoLayout;
private transient boolean lazyUpdate;
+ private transient int lazyFirstRow;
private transient Grid headerGrid;
@Override
public void encodeAll(FacesContext facesContext) throws IOException {
if (isLazy()) {
- if (getRows() == 0) {
- LOG.warn("Sheet id={} has lazy=true set, but not set the rows attribute!", getClientId(facesContext));
- }
- if (getShowRowRange() != ShowPosition.none) {
Review Comment:
Do we really want to delete the other warnings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org