You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/27 16:48:51 UTC

[GitHub] [shardingsphere] TeslaCN opened a new pull request #10512: Fix checkstyle for #10511

TeslaCN opened a new pull request #10512:
URL: https://github.com/apache/shardingsphere/pull/10512


   Revise #10511 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10512: Fix checkstyle for #10511

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10512:
URL: https://github.com/apache/shardingsphere/pull/10512#issuecomment-849808574


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10512?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10512](https://codecov.io/gh/apache/shardingsphere/pull/10512?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fab260) into [master](https://codecov.io/gh/apache/shardingsphere/commit/41f1335023c8ca10ba289b8d02ae29967045429d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41f1335) will **decrease** coverage by `0.09%`.
   > The diff coverage is `70.31%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10512/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #10512      +/-   ##
   ============================================
   - Coverage     68.81%   68.71%   -0.10%     
     Complexity      711      711              
   ============================================
     Files          1765     1771       +6     
     Lines         30272    30263       -9     
     Branches       5420     5420              
   ============================================
   - Hits          20831    20796      -35     
   - Misses         7837     7864      +27     
   + Partials       1604     1603       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10512?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...here/governance/core/registry/cache/CacheNode.java](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jYWNoZS9DYWNoZU5vZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ance/core/registry/cache/RegistryCacheManager.java](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jYWNoZS9SZWdpc3RyeUNhY2hlTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...service/config/impl/PropertiesRegistryService.java](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9zZXJ2aWNlL2NvbmZpZy9pbXBsL1Byb3BlcnRpZXNSZWdpc3RyeVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nce/core/registry/service/process/ProcessNode.java](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9zZXJ2aWNlL3Byb2Nlc3MvUHJvY2Vzc05vZGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...try/service/process/ProcessRegistrySubscriber.java](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9zZXJ2aWNlL3Byb2Nlc3MvUHJvY2Vzc1JlZ2lzdHJ5U3Vic2NyaWJlci5qYXZh) | `14.28% <0.00%> (-2.96%)` | :arrow_down: |
   | [...re/registry/service/state/LockRegistryService.java](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9zZXJ2aWNlL3N0YXRlL0xvY2tSZWdpc3RyeVNlcnZpY2UuamF2YQ==) | `42.42% <0.00%> (-1.70%)` | :arrow_down: |
   | [.../governance/core/registry/util/SchemaNameUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS91dGlsL1NjaGVtYU5hbWVVdGlsLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...service/config/impl/GlobalRuleRegistryService.java](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9zZXJ2aWNlL2NvbmZpZy9pbXBsL0dsb2JhbFJ1bGVSZWdpc3RyeVNlcnZpY2UuamF2YQ==) | `12.12% <11.11%> (-3.04%)` | :arrow_down: |
   | [...core/registry/cache/ScalingRegistrySubscriber.java](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9jYWNoZS9TY2FsaW5nUmVnaXN0cnlTdWJzY3JpYmVyLmphdmE=) | `64.70% <50.00%> (ø)` | |
   | [.../listener/impl/DataSourceStateChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9saXN0ZW5lci9pbXBsL0RhdGFTb3VyY2VTdGF0ZUNoYW5nZWRMaXN0ZW5lci5qYXZh) | `50.00% <50.00%> (-7.15%)` | :arrow_down: |
   | ... and [31 more](https://codecov.io/gh/apache/shardingsphere/pull/10512/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10512?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10512?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bce69c7...5fab260](https://codecov.io/gh/apache/shardingsphere/pull/10512?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss merged pull request #10512: Fix checkstyle for #10511

Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #10512:
URL: https://github.com/apache/shardingsphere/pull/10512


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org