You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jun He (Code Review)" <ge...@cloudera.org> on 2016/12/29 05:47:39 UTC
[kudu-CR] KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
Jun He has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5586
Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
......................................................................
KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
kudu-spark2 pom.xml is malformed due to a maven shade plugin issue:
dependency-reduced-pom should use shadedArtifactId
(https://issues.apache.org/jira/browse/MSHADE-155)
I upgraded maven-shade-plugin to version 2.4 and fixed the pom.xml.
Additionally, I moved the default properties to a default profile.
This makes the property settings consistent for both versions.
Change-Id: I0dc9ac261a82e13d189bc1be04faea5a9812d518
---
M java/kudu-spark/pom.xml
1 file changed, 15 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/5586/1
--
To view, visit http://gerrit.cloudera.org:8080/5586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dc9ac261a82e13d189bc1be04faea5a9812d518
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He <ju...@gmail.com>
[kudu-CR] KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
......................................................................
KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
kudu-spark2 pom.xml is malformed due to a maven shade plugin issue:
dependency-reduced-pom should use shadedArtifactId
(https://issues.apache.org/jira/browse/MSHADE-155)
I upgraded maven-shade-plugin to version 2.4 and fixed the pom.xml.
Additionally, I moved the default properties to a default profile.
This makes the property settings consistent for both versions.
Change-Id: I0dc9ac261a82e13d189bc1be04faea5a9812d518
Reviewed-on: http://gerrit.cloudera.org:8080/5586
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M java/kudu-spark/pom.xml
1 file changed, 15 insertions(+), 11 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0dc9ac261a82e13d189bc1be04faea5a9812d518
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He <ju...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
......................................................................
Patch Set 1: Code-Review+2
LGTM. I also manually checked that it's setting the properties correctly for the pom properties in the jars. I've added Dan and JD to the review and I'll give them a couple of days to weigh in if they want to before I submit it.
--
To view, visit http://gerrit.cloudera.org:8080/5586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0dc9ac261a82e13d189bc1be04faea5a9812d518
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He <ju...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No