You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/26 21:27:57 UTC

[GitHub] [incubator-superset] khtruong opened a new pull request #7391: feat: see Presto row and array data types

khtruong opened a new pull request #7391: feat: see Presto row and array data types
URL: https://github.com/apache/incubator-superset/pull/7391
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   If a column is an array or row, we did not show their data type in the schema view or its contents. For example, say we have ColumnA and its type is row(nest_obj double). 
   
   Previous Display:
   **ColumnA    NULL**
   - We would display ColumnA's data type as NULL and we would not display any information about nested_obj. 
   
   Current Display:
   **ColumnA     ROW
   ColumnA.nested_obj       double** 
   - Now we display ColumnA's data type and its contents.
   
   ### TEST PLAN
   Tested manually and wrote unit tests
   
   ### REVIEWERS
   @xtinec @DiggidyDave @datability-io @betodealmeida @john-bodley @graceguo-supercat @michellethomas 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org