You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/03/21 00:48:48 UTC

[GitHub] [incubator-mxnet] stu1130 opened a new pull request #14483: Reenable the test_kvstore_gpu.test_rsp_push_pull

stu1130 opened a new pull request #14483: Reenable the test_kvstore_gpu.test_rsp_push_pull
URL: https://github.com/apache/incubator-mxnet/pull/14483
 
 
   ## Description ##
   Ran 10k with latest MXNet code.
   ```
   TOTAL                                              18749  13965   6519     94    20%
   [success] 100.00% test_kvstore_gpu.test_rsp_push_pull: 22578.5869s
   ----------------------------------------------------------------------
   Ran 1 test in 22578.592s
   ```
   also test with seed 89411477 (module seed 1829754103),  seed 1155716252 (module seed 1032824746), all passed
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   
   
   ## Comments ##
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services