You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by arunmahadevan <gi...@git.apache.org> on 2018/08/21 22:40:12 UTC

[GitHub] storm pull request #2811: STORM-3184: Replace the usage of redact-value with...

GitHub user arunmahadevan opened a pull request:

    https://github.com/apache/storm/pull/2811

    STORM-3184: Replace the usage of redact-value with ConfigUtils.maskPasswords

    The topology submission can fail since redact-value expects a clojure map. We don't need redact-value, it can be replaced with ConfigUtils.maskPasswords. This is already done in master.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arunmahadevan/storm STORM-3184-followup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2811.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2811
    
----
commit 43faecc870468a00d5f1b2d5ba1c5c4274ae77b0
Author: Arun Mahadevan <ar...@...>
Date:   2018-08-20T23:31:32Z

    STORM-3184: Replace the usage of redact-value with ConfigUtils.maskPasswords
    
    The topology submission can fail since redact-value
    expects a clojure map. We dont need redact-value, it can be replaced
    with just ConfigUtils.maskPasswords. This is already done in master.

----


---

[GitHub] storm issue #2811: STORM-3184: Replace the usage of redact-value with Config...

Posted by arunmahadevan <gi...@git.apache.org>.

Github user arunmahadevan commented on the issue:

    https://github.com/apache/storm/pull/2811
  
    cc @HeartSaVioR 


---

[GitHub] storm pull request #2811: STORM-3184: Replace the usage of redact-value with...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2811


---

[GitHub] storm issue #2811: STORM-3184: Replace the usage of redact-value with Config...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2811
  
    Thanks @arunmahadevan , merged follow-up patch to 1.x-branch.


---