[GitHub] [rocketmq-externals] yuz10 commented on a change in pull request #744: [ISSUE #743] Implement RocketMQ message trace UI

[GitBox <gi...@apache.org>]

yuz10 commented on a change in pull request #744:
URL: https://github.com/apache/rocketmq-externals/pull/744#discussion_r663995671



##########
File path: rocketmq-console/src/main/java/org/apache/rocketmq/console/service/impl/MessageTraceServiceImpl.java
##########
@@ -51,4 +83,94 @@
             throw Throwables.propagate(err);
         }
     }
+
+    @Override
+    public MessageTraceGraph queryMessageTraceGraph(String key) {
+        List<MessageTraceView> messageTraceViews = queryMessageTraceKey(key);
+        return buildMessageTraceGraph(messageTraceViews);
+    }
+
+    private MessageTraceGraph buildMessageTraceGraph(List<MessageTraceView> messageTraceViews) {
+        MessageTraceGraph messageTraceGraph = new MessageTraceGraph();
+        messageTraceGraph.setMessageTraceViews(messageTraceViews);
+        if (CollectionUtils.isEmpty(messageTraceViews)) {
+            return messageTraceGraph;
+        }
+        ProducerNode producerNode = null;
+        Map<String, Map<String, Pair<MessageTraceView, MessageTraceView>>> messageTraceViewGroupMap = Maps.newHashMap();
+        for (MessageTraceView messageTraceView : messageTraceViews) {
+            switch (TraceType.valueOf(messageTraceView.getMsgType())) {
+                case Pub:
+                    producerNode = buildMessageRoot(messageTraceView);
+                    break;
+                case SubBefore:
+                case SubAfter:
+                    putIntoMessageTraceViewGroupMap(messageTraceView, messageTraceViewGroupMap);
+                    break;
+                default:
+                    break;
+            }
+        }
+        messageTraceGraph.setProducerNode(producerNode);
+        messageTraceGraph.setSubscriptionNodeList(buildSubscriptionNodeList(messageTraceViewGroupMap));
+        return messageTraceGraph;
+    }
+
+    private List<SubscriptionNode> buildSubscriptionNodeList(
+        Map<String, Map<String, Pair<MessageTraceView, MessageTraceView>>> messageTraceViewGroupMap) {
+        List<SubscriptionNode> subscriptionNodeList = new ArrayList<>(messageTraceViewGroupMap.size());
+        for (Map.Entry<String, Map<String, Pair<MessageTraceView, MessageTraceView>>> groupTraceView : messageTraceViewGroupMap
+            .entrySet()) {
+            SubscriptionNode subscriptionNode = new SubscriptionNode();
+            subscriptionNode.setSubscriptionGroup(groupTraceView.getKey());
+            List<TraceNode> consumeNodeList = Lists.newArrayList();
+            subscriptionNode.setConsumeNodeList(consumeNodeList);
+            subscriptionNodeList.add(subscriptionNode);
+            for (Map.Entry<String, Pair<MessageTraceView, MessageTraceView>> requestIdTracePair : groupTraceView
+                .getValue().entrySet()) {
+                MessageTraceView subBeforeTrace = requestIdTracePair.getValue().getObject1();
+                MessageTraceView subAfterTrace = requestIdTracePair.getValue().getObject2();
+                TraceNode consumeNode = new TraceNode();
+                consumeNode.setRequestId(requestIdTracePair.getKey());
+                consumeNode.setStoreHost(subBeforeTrace.getStoreHost());
+                consumeNode.setClientHost(subBeforeTrace.getClientHost());
+                consumeNode.setRetryTimes(subBeforeTrace.getRetryTimes());
+                consumeNode.setBeginTimeStamp(subBeforeTrace.getTimeStamp());
+                consumeNode.setCostTime(subAfterTrace.getCostTime());
+                consumeNode.setEndTimeStamp(subAfterTrace.getTimeStamp());
+                consumeNode.setStatus(subAfterTrace.getStatus());
+                consumeNodeList.add(consumeNode);
+            }
+        }
+        return subscriptionNodeList;
+    }
+
+    private void putIntoMessageTraceViewGroupMap(MessageTraceView messageTraceView,
+        Map<String, Map<String, Pair<MessageTraceView, MessageTraceView>>> messageTraceViewGroupMap) {
+        Map<String, Pair<MessageTraceView, MessageTraceView>> requestIdTraceMap = messageTraceViewGroupMap
+            .computeIfAbsent(messageTraceView.getGroupName(), (o) -> new HashMap<>(2));

Review comment:
       the newest commit of rocketmq has removed groupname field of SubAfter trace, so you will not be able to match the pair in later releases.   see  https://github.com/apache/rocketmq/pull/3005/files
   
   this will result null exception at: org.apache.rocketmq.console.service.impl.MessageTraceServiceImpl.buildSubscriptionNodeList(MessageTraceServiceImpl.java:135)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org