You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by mlegenhausen <gi...@git.apache.org> on 2015/07/17 15:51:25 UTC
[GitHub] cordova-android pull request: cdvBuildMultipleApks casting fixed
GitHub user mlegenhausen opened a pull request:
https://github.com/apache/cordova-android/pull/199
cdvBuildMultipleApks casting fixed
Casting `cdvBuildMultipleApks` via `!!` does not work when you want to modify the build process via the command line. The problem can be simply reproduced when running: `cordova build android -- --gradleArg=-PcdvBuildMultipleApks=false`. The expected output would be a build with a single apk. But the result is a build with multiple apks cause `!!"false"` is `true`. This fix solves the problem by using an more mature casting process that also can handle string that contain the value `"false"`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/werk85/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/199.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #199
----
commit 9853a15163d3e4d47865ecb414e54844146f3d74
Author: Malte Legenhausen <ml...@gmail.com>
Date: 2015-07-17T13:51:10Z
cdvBuildMultipleApks casting fixed
Casting `cdvBuildMultipleApks` via `!!` does not work when you want to modify the build process via the command line. The problem can be simply reproduced when running: `cordova build android -- --gradleArg=-PcdvBuildMultipleApks=false`. The expected output would be a build with a single apk. But the result is a build with multiple apks cause `!!"false"` is `true`. This fix solves the problem by using an more mature casting process that also can handle string that contain the value `"false"`.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: cdvBuildMultipleApks casting fixed
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/199#issuecomment-122875696
Created JIRA: https://issues.apache.org/jira/browse/CB-9391
LGTM, merging. @mlegenhausen, if you're going to contribute to Apache projects, please sign Apache's Contributor License Agreement (can be done online): http://www.apache.org/licenses/#clas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: cdvBuildMultipleApks casting fixed
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: cdvBuildMultipleApks casting fixed
Posted by mlegenhausen <gi...@git.apache.org>.
Github user mlegenhausen commented on the pull request:
https://github.com/apache/cordova-android/pull/199#issuecomment-122279880
I found a workaround: `cordova build android -- --gradleArg=-PcdvBuildMultipleApks=''`. The problem really bothers when you want to use the `cordova-plugin-crosswalk-webview` where the `cdvBuildMultipleApks` value is set to `true` as default and can not be reseted via the described command above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org