You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2025/02/05 03:46:55 UTC
[PR] [SPARK-50949][ML][PYTHON][CONNECT][FOLLOW-UP] Fix uid issue and empty array args [spark]
zhengruifeng opened a new pull request, #49802:
URL: https://github.com/apache/spark/pull/49802
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
1, pass the uid
2, fix empty array args
### Why are the changes needed?
to enable parity test
### Does this PR introduce _any_ user-facing change?
yes, bug fix
### How was this patch tested?
enabled tests
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50949][ML][PYTHON][CONNECT][FOLLOW-UP] Fix uid issue and empty array args [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #49802:
URL: https://github.com/apache/spark/pull/49802#issuecomment-2635727905
merged to master/4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50949][ML][PYTHON][CONNECT][FOLLOW-UP] Fix uid issue and empty array args [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #49802:
URL: https://github.com/apache/spark/pull/49802#discussion_r1942207493
##########
python/pyspark/ml/connect/serialize.py:
##########
@@ -131,11 +132,19 @@ def serialize_param(value: Any, client: "SparkConnectClient") -> pb2.Expression.
def serialize(client: "SparkConnectClient", *args: Any) -> List[Any]:
from pyspark.sql.connect.dataframe import DataFrame as ConnectDataFrame
+ from pyspark.sql.connect.expressions import LiteralExpression
result = []
for arg in args:
if isinstance(arg, ConnectDataFrame):
result.append(pb2.Fetch.Method.Args(input=arg._plan.plan(client)))
+ elif isinstance(arg, tuple) and len(arg) == 2 and isinstance(arg[1], DataType):
Review Comment:
we can not infer the datatype from an empty list, so we need a way to specify the type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50949][ML][PYTHON][CONNECT][FOLLOW-UP] Fix uid issue and empty array args [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #49802: [SPARK-50949][ML][PYTHON][CONNECT][FOLLOW-UP] Fix uid issue and empty array args
URL: https://github.com/apache/spark/pull/49802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org