You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/05/05 18:44:12 UTC
svn commit: r1889530 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java
Author: tilman
Date: Wed May 5 18:44:12 2021
New Revision: 1889530
URL: http://svn.apache.org/viewvc?rev=1889530&view=rev
Log:
PDFBOX-4892: avoid memory leak for last writer in collection, as suggested by valerybokov
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java?rev=1889530&r1=1889529&r2=1889530&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/image/JPEGFactory.java Wed May 5 18:44:12 2021
@@ -349,15 +349,10 @@ public final class JPEGFactory
private static ImageWriter getJPEGImageWriter() throws IOException
{
- ImageWriter writer = null;
Iterator<ImageWriter> writers = ImageIO.getImageWritersBySuffix("jpeg");
while (writers.hasNext())
{
- if (writer != null)
- {
- writer.dispose();
- }
- writer = writers.next();
+ ImageWriter writer = writers.next();
if (writer == null)
{
continue;
@@ -367,6 +362,7 @@ public final class JPEGFactory
{
return writer;
}
+ writer.dispose();
}
throw new IOException("No ImageWriter found for JPEG format");
}