[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #271: bugfix tracing filter and add samples

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #271:
URL: https://github.com/apache/dubbo-go-pixiu/pull/271#discussion_r723966011



##########
File path: pkg/filter/tracing/tracing.go
##########
@@ -51,28 +50,52 @@ func init() {
 }
 
 // tracerFilter is a filter for tracer
-type Plugin struct {
-}
+type (
+	Plugin struct {
+	}
+	TraceFilter struct {
+		cfg *TraceConfig
+	}
 
-type TraceFilter struct {
-}
+	// Tracing
+	TraceConfig struct {
+		Http Http   `yaml:"http" json:"http,omitempty"`
+		URL  string `yaml:"url" json:"url,omitempty"`
+		Type string `yaml:"type" json:"type,omitempty"`
+	}
+
+	// Tracing
+	Http struct {

Review comment:
       怎么取这么一个名字？不明白这是要干啥




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org