You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2016/04/25 11:06:04 UTC
Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config
calculations used by LLAP app. and fixes for AMBARI-16079,
AMBARI-16086, AMBARI-16087
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/
-----------------------------------------------------------
(Updated April 25, 2016, 9:06 a.m.)
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Summary (updated)
-----------------
AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087
Bugs: AMBARI-16078.patch
https://issues.apache.org/jira/browse/AMBARI-16078.patch
Repository: ambari
Description
-------
Fix for :
(1). AMBARI-16078. Config calculations used by LLAP app.
Trivial fixes for :
(2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
(3). AMBARI-16086. Hide HSI related sliders when 'llap' queue is not being used.
(4). AMBARI-16087. LLAP queue is not selected when enabling Hive Interactive Query during Install Wizard
AMBARI-16078:
============
- Calculated in Stack advisor code whenever : LLAP queue is in selection and (1). HSI is enabled or (2). change done to slider HSI slider "% of Cluster Capacity" , or (3). change done to slider HSI slider 'Number of Daemon Instances'
-
- caluclations are not done if the overall cluster state is not conduciv for meaningful run of LLAP.
AMBARI-16079:
=============
Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, the overall workability of app may not be ascertained.
As of now, using llap0 name, app does go into RUNNING_ALL state.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f548ea3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a044fda
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml 816e207
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 21d1109
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4da21fa
ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 44759a9
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3934301
ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02
Diff: https://reviews.apache.org/r/46600/diff/
Testing
-------
- Python tests added.
- Python UT passes.
----------------------------------------------------------------------
Ran 261 tests in 7.091s
OK
----------------------------------------------------------------------
Total run:995
Total errors:0
Total failures:0
OK
Thanks,
Swapan Shridhar
Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config
calculations used by LLAP app. and fixes for AMBARI-16079,
AMBARI-16086, AMBARI-16087
Posted by Siddharth Seth <ss...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/#review130379
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 212)
<https://reviews.apache.org/r/46600/#comment194112>
loglevel needs to be a separate field in the UI. tez_am_log_level is not related to the LLAP log level.
Will be an env setting similar to xmx
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 368)
<https://reviews.apache.org/r/46600/#comment194113>
Not sure what this exception causes, but can it include the number of running instances as well as number of desired ?
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml (line 70)
<https://reviews.apache.org/r/46600/#comment194122>
This seems like a strange mechanism to trasnfer information from the UI to the backend script. These new parameters have no meaning to hive itself. Is there an alternate technique in Ambari to trasnfer this information to the backend - instead of piggybacking on component scripts ?
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 186)
<https://reviews.apache.org/r/46600/#comment194114>
"hive-interactive-site" should be a constant given the number of times it is being referenced as a string literal.
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 491)
<https://reviews.apache.org/r/46600/#comment194127>
Simpler for this to be NM_CONTAINER_SIZE.
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 534)
<https://reviews.apache.org/r/46600/#comment194125>
normalizeUp(self.calculate_slider_am_size) - Ensure a full container is accounted for.
Not requried in the other place where this method is used (that I believe is setting the value which is actually used).
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 580)
<https://reviews.apache.org/r/46600/#comment194124>
Rename to get_hive_am_container_size. llap_daemon_container_size is very different and computed later.
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 603)
<https://reviews.apache.org/r/46600/#comment194128>
We'll likely need a fallback to go and figure out how many CPUs exist on a node. This would be determined elsewhere in stack_advisor to setup the property for YARN.
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 629)
<https://reviews.apache.org/r/46600/#comment194129>
Rename to calculate_llap_cache_size_per_executor
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 645)
<https://reviews.apache.org/r/46600/#comment194130>
Eventually, we may need some more changes here based on another config settings - but I think that can be added later.
For reference: this is related to using direct memory or an on-heap cache.
- Siddharth Seth
On April 25, 2016, 10:07 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46600/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 10:07 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-16078, AMBARI-16079, AMBARI-16086, and AMBARI-16087
> https://issues.apache.org/jira/browse/AMBARI-16078
> https://issues.apache.org/jira/browse/AMBARI-16079
> https://issues.apache.org/jira/browse/AMBARI-16086
> https://issues.apache.org/jira/browse/AMBARI-16087
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix for :
> (1). AMBARI-16078. Config calculations used by LLAP app.
>
> Trivial fixes for :
>
> (2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
> (3). AMBARI-16086. Hide HSI related sliders when 'llap' queue is not being used.
> (4). AMBARI-16087. LLAP queue is not selected when enabling Hive Interactive Query during Install Wizard
>
> AMBARI-16078:
> ============
> - Calculated in Stack advisor code whenever : LLAP queue is in selection and (1). HSI is enabled or (2). change done to slider HSI slider "% of Cluster Capacity" , or (3). change done to slider HSI slider 'Number of Daemon Instances'
> -
> - caluclations are not done if the overall cluster state is not conduciv for meaningful run of LLAP.
>
> AMBARI-16079:
> =============
>
> Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, the overall workability of app may not be ascertained.
> As of now, using llap0 name, app does go into RUNNING_ALL state.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f548ea3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a044fda
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml 816e207
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 21d1109
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4da21fa
> ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 44759a9
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3934301
> ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02
>
> Diff: https://reviews.apache.org/r/46600/diff/
>
>
> Testing
> -------
>
> - Python tests added.
> - Python UT passes.
>
>
> ----------------------------------------------------------------------
> Ran 261 tests in 7.091s
>
> OK
> ----------------------------------------------------------------------
> Total run:995
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config
calculations used by LLAP app. and fixes for AMBARI-16079,
AMBARI-16086, AMBARI-16087
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/#review130420
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On April 25, 2016, 10:07 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46600/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 10:07 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-16078, AMBARI-16079, AMBARI-16086, and AMBARI-16087
> https://issues.apache.org/jira/browse/AMBARI-16078
> https://issues.apache.org/jira/browse/AMBARI-16079
> https://issues.apache.org/jira/browse/AMBARI-16086
> https://issues.apache.org/jira/browse/AMBARI-16087
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix for :
> (1). AMBARI-16078. Config calculations used by LLAP app.
>
> Trivial fixes for :
>
> (2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
> (3). AMBARI-16086. Hide HSI related sliders when 'llap' queue is not being used.
> (4). AMBARI-16087. LLAP queue is not selected when enabling Hive Interactive Query during Install Wizard
>
> AMBARI-16078:
> ============
> - Calculated in Stack advisor code whenever : LLAP queue is in selection and (1). HSI is enabled or (2). change done to slider HSI slider "% of Cluster Capacity" , or (3). change done to slider HSI slider 'Number of Daemon Instances'
> -
> - caluclations are not done if the overall cluster state is not conduciv for meaningful run of LLAP.
>
> AMBARI-16079:
> =============
>
> Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, the overall workability of app may not be ascertained.
> As of now, using llap0 name, app does go into RUNNING_ALL state.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f548ea3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a044fda
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml 816e207
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 21d1109
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4da21fa
> ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 44759a9
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3934301
> ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02
>
> Diff: https://reviews.apache.org/r/46600/diff/
>
>
> Testing
> -------
>
> - Python tests added.
> - Python UT passes.
>
>
> ----------------------------------------------------------------------
> Ran 261 tests in 7.091s
>
> OK
> ----------------------------------------------------------------------
> Total run:995
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config
calculations used by LLAP app. and fixes for AMBARI-16079,
AMBARI-16086, AMBARI-16087
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/#review130520
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 25, 2016, 11:37 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46600/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 11:37 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-16078, AMBARI-16079, AMBARI-16086, and AMBARI-16087
> https://issues.apache.org/jira/browse/AMBARI-16078
> https://issues.apache.org/jira/browse/AMBARI-16079
> https://issues.apache.org/jira/browse/AMBARI-16086
> https://issues.apache.org/jira/browse/AMBARI-16087
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix for :
> (1). AMBARI-16078. Config calculations used by LLAP app.
>
> Trivial fixes for :
>
> (2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
> (3). AMBARI-16086. Hide HSI related sliders when 'llap' queue is not being used.
> (4). AMBARI-16087. LLAP queue is not selected when enabling Hive Interactive Query during Install Wizard
>
> AMBARI-16078:
> ============
> - Calculated in Stack advisor code whenever : LLAP queue is in selection and (1). HSI is enabled or (2). change done to slider HSI slider "% of Cluster Capacity" , or (3). change done to slider HSI slider 'Number of Daemon Instances'
> -
> - caluclations are not done if the overall cluster state is not conduciv for meaningful run of LLAP.
>
> AMBARI-16079:
> =============
>
> Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, the overall workability of app may not be ascertained.
> As of now, using llap0 name, app does go into RUNNING_ALL state.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f548ea3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a044fda
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml 816e207
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 21d1109
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 4e1a54b
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4da21fa
> ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 44759a9
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3934301
> ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02
>
> Diff: https://reviews.apache.org/r/46600/diff/
>
>
> Testing
> -------
>
> - Python tests added.
> - Python UT passes.
>
>
> ----------------------------------------------------------------------
> Ran 261 tests in 7.091s
>
> OK
> ----------------------------------------------------------------------
> Total run:995
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config
calculations used by LLAP app. and fixes for AMBARI-16079,
AMBARI-16086, AMBARI-16087
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/
-----------------------------------------------------------
(Updated April 25, 2016, 11:37 p.m.)
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Changes
-------
Added Sid's suggestions and fixed few corener cases.
Bugs: AMBARI-16078, AMBARI-16079, AMBARI-16086, and AMBARI-16087
https://issues.apache.org/jira/browse/AMBARI-16078
https://issues.apache.org/jira/browse/AMBARI-16079
https://issues.apache.org/jira/browse/AMBARI-16086
https://issues.apache.org/jira/browse/AMBARI-16087
Repository: ambari
Description
-------
Fix for :
(1). AMBARI-16078. Config calculations used by LLAP app.
Trivial fixes for :
(2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
(3). AMBARI-16086. Hide HSI related sliders when 'llap' queue is not being used.
(4). AMBARI-16087. LLAP queue is not selected when enabling Hive Interactive Query during Install Wizard
AMBARI-16078:
============
- Calculated in Stack advisor code whenever : LLAP queue is in selection and (1). HSI is enabled or (2). change done to slider HSI slider "% of Cluster Capacity" , or (3). change done to slider HSI slider 'Number of Daemon Instances'
-
- caluclations are not done if the overall cluster state is not conduciv for meaningful run of LLAP.
AMBARI-16079:
=============
Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, the overall workability of app may not be ascertained.
As of now, using llap0 name, app does go into RUNNING_ALL state.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f548ea3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a044fda
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml 816e207
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 21d1109
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 4e1a54b
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4da21fa
ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 44759a9
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3934301
ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02
Diff: https://reviews.apache.org/r/46600/diff/
Testing
-------
- Python tests added.
- Python UT passes.
----------------------------------------------------------------------
Ran 261 tests in 7.091s
OK
----------------------------------------------------------------------
Total run:995
Total errors:0
Total failures:0
OK
Thanks,
Swapan Shridhar
Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config
calculations used by LLAP app. and fixes for AMBARI-16079,
AMBARI-16086, AMBARI-16087
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/#review130470
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 25, 2016, 10:07 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46600/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 10:07 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-16078, AMBARI-16079, AMBARI-16086, and AMBARI-16087
> https://issues.apache.org/jira/browse/AMBARI-16078
> https://issues.apache.org/jira/browse/AMBARI-16079
> https://issues.apache.org/jira/browse/AMBARI-16086
> https://issues.apache.org/jira/browse/AMBARI-16087
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix for :
> (1). AMBARI-16078. Config calculations used by LLAP app.
>
> Trivial fixes for :
>
> (2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
> (3). AMBARI-16086. Hide HSI related sliders when 'llap' queue is not being used.
> (4). AMBARI-16087. LLAP queue is not selected when enabling Hive Interactive Query during Install Wizard
>
> AMBARI-16078:
> ============
> - Calculated in Stack advisor code whenever : LLAP queue is in selection and (1). HSI is enabled or (2). change done to slider HSI slider "% of Cluster Capacity" , or (3). change done to slider HSI slider 'Number of Daemon Instances'
> -
> - caluclations are not done if the overall cluster state is not conduciv for meaningful run of LLAP.
>
> AMBARI-16079:
> =============
>
> Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, the overall workability of app may not be ascertained.
> As of now, using llap0 name, app does go into RUNNING_ALL state.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f548ea3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a044fda
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml 816e207
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 21d1109
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4da21fa
> ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 44759a9
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3934301
> ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02
>
> Diff: https://reviews.apache.org/r/46600/diff/
>
>
> Testing
> -------
>
> - Python tests added.
> - Python UT passes.
>
>
> ----------------------------------------------------------------------
> Ran 261 tests in 7.091s
>
> OK
> ----------------------------------------------------------------------
> Total run:995
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config
calculations used by LLAP app. and fixes for AMBARI-16079,
AMBARI-16086, AMBARI-16087
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/
-----------------------------------------------------------
(Updated April 25, 2016, 10:07 a.m.)
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Changes
-------
Removed redundant check in llap queue creation/updation
Bugs: AMBARI-16078, AMBARI-16079, AMBARI-16086, and AMBARI-16087
https://issues.apache.org/jira/browse/AMBARI-16078
https://issues.apache.org/jira/browse/AMBARI-16079
https://issues.apache.org/jira/browse/AMBARI-16086
https://issues.apache.org/jira/browse/AMBARI-16087
Repository: ambari
Description
-------
Fix for :
(1). AMBARI-16078. Config calculations used by LLAP app.
Trivial fixes for :
(2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
(3). AMBARI-16086. Hide HSI related sliders when 'llap' queue is not being used.
(4). AMBARI-16087. LLAP queue is not selected when enabling Hive Interactive Query during Install Wizard
AMBARI-16078:
============
- Calculated in Stack advisor code whenever : LLAP queue is in selection and (1). HSI is enabled or (2). change done to slider HSI slider "% of Cluster Capacity" , or (3). change done to slider HSI slider 'Number of Daemon Instances'
-
- caluclations are not done if the overall cluster state is not conduciv for meaningful run of LLAP.
AMBARI-16079:
=============
Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, the overall workability of app may not be ascertained.
As of now, using llap0 name, app does go into RUNNING_ALL state.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f548ea3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a044fda
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml 816e207
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 21d1109
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4da21fa
ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 44759a9
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3934301
ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02
Diff: https://reviews.apache.org/r/46600/diff/
Testing
-------
- Python tests added.
- Python UT passes.
----------------------------------------------------------------------
Ran 261 tests in 7.091s
OK
----------------------------------------------------------------------
Total run:995
Total errors:0
Total failures:0
OK
Thanks,
Swapan Shridhar
Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config
calculations used by LLAP app. and fixes for AMBARI-16079,
AMBARI-16086, AMBARI-16087
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/
-----------------------------------------------------------
(Updated April 25, 2016, 9:31 a.m.)
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Changes
-------
Provided default value for hive-interactive-env/llap_heap_size = 0.
Bugs: AMBARI-16078, AMBARI-16079, AMBARI-16086, and AMBARI-16087
https://issues.apache.org/jira/browse/AMBARI-16078
https://issues.apache.org/jira/browse/AMBARI-16079
https://issues.apache.org/jira/browse/AMBARI-16086
https://issues.apache.org/jira/browse/AMBARI-16087
Repository: ambari
Description
-------
Fix for :
(1). AMBARI-16078. Config calculations used by LLAP app.
Trivial fixes for :
(2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
(3). AMBARI-16086. Hide HSI related sliders when 'llap' queue is not being used.
(4). AMBARI-16087. LLAP queue is not selected when enabling Hive Interactive Query during Install Wizard
AMBARI-16078:
============
- Calculated in Stack advisor code whenever : LLAP queue is in selection and (1). HSI is enabled or (2). change done to slider HSI slider "% of Cluster Capacity" , or (3). change done to slider HSI slider 'Number of Daemon Instances'
-
- caluclations are not done if the overall cluster state is not conduciv for meaningful run of LLAP.
AMBARI-16079:
=============
Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, the overall workability of app may not be ascertained.
As of now, using llap0 name, app does go into RUNNING_ALL state.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f548ea3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a044fda
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml 816e207
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 21d1109
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4da21fa
ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 44759a9
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3934301
ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02
Diff: https://reviews.apache.org/r/46600/diff/
Testing
-------
- Python tests added.
- Python UT passes.
----------------------------------------------------------------------
Ran 261 tests in 7.091s
OK
----------------------------------------------------------------------
Total run:995
Total errors:0
Total failures:0
OK
Thanks,
Swapan Shridhar
Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config
calculations used by LLAP app. and fixes for AMBARI-16079,
AMBARI-16086, AMBARI-16087
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/
-----------------------------------------------------------
(Updated April 25, 2016, 9:07 a.m.)
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Changes
-------
Update Bugs.
Bugs: AMBARI-16078, AMBARI-16079, AMBARI-16086, and AMBARI-16087
https://issues.apache.org/jira/browse/AMBARI-16078
https://issues.apache.org/jira/browse/AMBARI-16079
https://issues.apache.org/jira/browse/AMBARI-16086
https://issues.apache.org/jira/browse/AMBARI-16087
Repository: ambari
Description
-------
Fix for :
(1). AMBARI-16078. Config calculations used by LLAP app.
Trivial fixes for :
(2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
(3). AMBARI-16086. Hide HSI related sliders when 'llap' queue is not being used.
(4). AMBARI-16087. LLAP queue is not selected when enabling Hive Interactive Query during Install Wizard
AMBARI-16078:
============
- Calculated in Stack advisor code whenever : LLAP queue is in selection and (1). HSI is enabled or (2). change done to slider HSI slider "% of Cluster Capacity" , or (3). change done to slider HSI slider 'Number of Daemon Instances'
-
- caluclations are not done if the overall cluster state is not conduciv for meaningful run of LLAP.
AMBARI-16079:
=============
Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, the overall workability of app may not be ascertained.
As of now, using llap0 name, app does go into RUNNING_ALL state.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py f548ea3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py a044fda
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml 816e207
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml 21d1109
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4da21fa
ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 44759a9
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3934301
ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02
Diff: https://reviews.apache.org/r/46600/diff/
Testing
-------
- Python tests added.
- Python UT passes.
----------------------------------------------------------------------
Ran 261 tests in 7.091s
OK
----------------------------------------------------------------------
Total run:995
Total errors:0
Total failures:0
OK
Thanks,
Swapan Shridhar