You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/08/24 07:04:02 UTC
Review Request 13701: Automation Tests for HA Proxy Stickiness
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Automation Tests for HA Proxy Stickiness
Diffs
-----
test/integration/component/test_haproxy.py PRE-CREATION
Diff: https://reviews.apache.org/r/13701/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 13701: Automation Tests for HA Proxy Stickiness
Posted by venkata swamy babu budumuru <ve...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/#review25925
-----------------------------------------------------------
test/integration/component/test_haproxy.py
<https://reviews.apache.org/r/13701/#comment50605>
can we move configs dictionary to top along with lb_methods?
test/integration/component/test_haproxy.py
<https://reviews.apache.org/r/13701/#comment50606>
Didn't quite understand what this test is qualifying
- if we create a sticky policy when router is down, we can see the same immediately with listLBStickinessPolicies even before the router starts.
- I think the test adds value if we can login to the router and check whether the policy is configure once the router is back online.
test/integration/component/test_haproxy.py
<https://reviews.apache.org/r/13701/#comment50607>
destroying a router shouldn't delete the stickiness policy but the description says so. Can you confirm whether you saw some behaviour like that?
test/integration/component/test_haproxy.py
<https://reviews.apache.org/r/13701/#comment50608>
there is no test for #adding same rule again though the doc string says there is.
- venkata swamy babu budumuru
On Aug. 27, 2013, 5:36 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13701/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2013, 5:36 a.m.)
>
>
> Review request for cloudstack, suresh sadhu and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation Tests for HA Proxy Stickiness
>
>
> Diffs
> -----
>
> test/integration/component/test_haproxy.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13701/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13701: Automation Tests for HA Proxy Stickiness
Posted by suresh sadhu <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/#review26061
-----------------------------------------------------------
test/integration/component/test_haproxy.py
<https://reviews.apache.org/r/13701/#comment50874>
This method is only checking by listing the created Stickinesspolices but not really validating the configured stickiness policy is working or not.
It should validate stickiness functionality by checking whether the request is always is going to same destination or not after defining the stickiness policy.
- suresh sadhu
On Aug. 27, 2013, 5:36 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13701/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2013, 5:36 a.m.)
>
>
> Review request for cloudstack, suresh sadhu and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation Tests for HA Proxy Stickiness
>
>
> Diffs
> -----
>
> test/integration/component/test_haproxy.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13701/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13701: Automation Tests for HA Proxy Stickiness
Posted by suresh sadhu <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/#review26060
-----------------------------------------------------------
test/integration/component/test_haproxy.py
<https://reviews.apache.org/r/13701/#comment50871>
def test_03_supported_policies_by_network
This method is checking only tag "supported Stickynessmethods" but not checking displayed supported methods under this tag.
script should retrive and compare the displayed value with supported values.
if both matches then it should return true.
- suresh sadhu
On Aug. 27, 2013, 5:36 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13701/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2013, 5:36 a.m.)
>
>
> Review request for cloudstack, suresh sadhu and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation Tests for HA Proxy Stickiness
>
>
> Diffs
> -----
>
> test/integration/component/test_haproxy.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13701/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13701: Automation Tests for HA Proxy Stickiness
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/#review27007
-----------------------------------------------------------
Ship it!
commit 56ccb2835b28c04bbecc3910b20cc5c0b016bda5
Author: Girish Shilamkar <gi...@clogeny.com>
Date: Thu Oct 10 02:21:47 2013 -0400
Automation Tests for HA Proxy Stickiness
Reviewed-by: Suresh Sadhu <Su...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
Please watch out for failures in the tests. They have been included in the test run
- Prasanna Santhanam
On Oct. 11, 2013, 7:23 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13701/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 7:23 a.m.)
>
>
> Review request for cloudstack, suresh sadhu and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation Tests for HA Proxy Stickiness
>
>
> Diffs
> -----
>
> test/integration/component/test_haproxy.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13701/diff/
>
>
> Testing
> -------
>
> est_01_create_sticky_policy_default_values (test_haproxy.TestHAProxyStickyness)
> Test Configure stickiness policies with default values ... ok
> test_02_create_sticky_policy_custom_values (test_haproxy.TestHAProxyStickyness)
> Test Configure stickiness policies with custom values ... ok
> test_03_supported_policies_by_network (test_haproxy.TestHAProxyStickyness)
> Test listnetworks response to check supported stickiness policies ... ok
> test_04_delete_lb_rule (test_haproxy.TestHAProxyStickyness)
> Test LB rule before/after stickiness policy creation ... ok
> test_05_error_alerts_after_create (test_haproxy.TestHAProxyStickyness)
> Test error/alerts after creating stickiness policy ... ok
> test_06_release_ip (test_haproxy.TestHAProxyStickyness)
> Test release public IP with stickiness policy ... ok
> test_07_delete_account (test_haproxy.TestHAProxyStickyness)
> Test Delete account and check the router and its rules ... ok
> test_08_create_policy_router_stopped (test_haproxy.TestHAProxyStickyness)
> Test verify create stickiness policy when router is stopped state ... ok
> test_09_create_policy_router_destroy (test_haproxy.TestHAProxyStickyness)
> Test check the stickiness policy rules after destroying router ... ok
> test_10_create_policy_enable_disable_vpn (test_haproxy.TestHAProxyStickyness)
> Test enable/disable the VPN after applying sticky policy rules ... ok
> test_11_invalid_params (test_haproxy.TestHAProxyStickyness)
> Test verfify functionality syncronous and asyncronous validations ... ok
>
> ----------------------------------------------------------------------
> Ran 11 tests in 2154.059s
>
> OK
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13701: Automation Tests for HA Proxy Stickiness
Posted by suresh sadhu <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/#review26927
-----------------------------------------------------------
Ship it!
patch looks ok
- suresh sadhu
On Oct. 11, 2013, 7:23 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13701/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 7:23 a.m.)
>
>
> Review request for cloudstack, suresh sadhu and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation Tests for HA Proxy Stickiness
>
>
> Diffs
> -----
>
> test/integration/component/test_haproxy.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13701/diff/
>
>
> Testing
> -------
>
> est_01_create_sticky_policy_default_values (test_haproxy.TestHAProxyStickyness)
> Test Configure stickiness policies with default values ... ok
> test_02_create_sticky_policy_custom_values (test_haproxy.TestHAProxyStickyness)
> Test Configure stickiness policies with custom values ... ok
> test_03_supported_policies_by_network (test_haproxy.TestHAProxyStickyness)
> Test listnetworks response to check supported stickiness policies ... ok
> test_04_delete_lb_rule (test_haproxy.TestHAProxyStickyness)
> Test LB rule before/after stickiness policy creation ... ok
> test_05_error_alerts_after_create (test_haproxy.TestHAProxyStickyness)
> Test error/alerts after creating stickiness policy ... ok
> test_06_release_ip (test_haproxy.TestHAProxyStickyness)
> Test release public IP with stickiness policy ... ok
> test_07_delete_account (test_haproxy.TestHAProxyStickyness)
> Test Delete account and check the router and its rules ... ok
> test_08_create_policy_router_stopped (test_haproxy.TestHAProxyStickyness)
> Test verify create stickiness policy when router is stopped state ... ok
> test_09_create_policy_router_destroy (test_haproxy.TestHAProxyStickyness)
> Test check the stickiness policy rules after destroying router ... ok
> test_10_create_policy_enable_disable_vpn (test_haproxy.TestHAProxyStickyness)
> Test enable/disable the VPN after applying sticky policy rules ... ok
> test_11_invalid_params (test_haproxy.TestHAProxyStickyness)
> Test verfify functionality syncronous and asyncronous validations ... ok
>
> ----------------------------------------------------------------------
> Ran 11 tests in 2154.059s
>
> OK
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 13701: Automation Tests for HA Proxy Stickiness
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/
-----------------------------------------------------------
(Updated Oct. 11, 2013, 7:23 a.m.)
Review request for cloudstack, suresh sadhu and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Automation Tests for HA Proxy Stickiness
Diffs (updated)
-----
test/integration/component/test_haproxy.py PRE-CREATION
Diff: https://reviews.apache.org/r/13701/diff/
Testing (updated)
-------
est_01_create_sticky_policy_default_values (test_haproxy.TestHAProxyStickyness)
Test Configure stickiness policies with default values ... ok
test_02_create_sticky_policy_custom_values (test_haproxy.TestHAProxyStickyness)
Test Configure stickiness policies with custom values ... ok
test_03_supported_policies_by_network (test_haproxy.TestHAProxyStickyness)
Test listnetworks response to check supported stickiness policies ... ok
test_04_delete_lb_rule (test_haproxy.TestHAProxyStickyness)
Test LB rule before/after stickiness policy creation ... ok
test_05_error_alerts_after_create (test_haproxy.TestHAProxyStickyness)
Test error/alerts after creating stickiness policy ... ok
test_06_release_ip (test_haproxy.TestHAProxyStickyness)
Test release public IP with stickiness policy ... ok
test_07_delete_account (test_haproxy.TestHAProxyStickyness)
Test Delete account and check the router and its rules ... ok
test_08_create_policy_router_stopped (test_haproxy.TestHAProxyStickyness)
Test verify create stickiness policy when router is stopped state ... ok
test_09_create_policy_router_destroy (test_haproxy.TestHAProxyStickyness)
Test check the stickiness policy rules after destroying router ... ok
test_10_create_policy_enable_disable_vpn (test_haproxy.TestHAProxyStickyness)
Test enable/disable the VPN after applying sticky policy rules ... ok
test_11_invalid_params (test_haproxy.TestHAProxyStickyness)
Test verfify functionality syncronous and asyncronous validations ... ok
----------------------------------------------------------------------
Ran 11 tests in 2154.059s
OK
Thanks,
Girish Shilamkar
Re: Review Request 13701: Automation Tests for HA Proxy Stickiness
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13701/
-----------------------------------------------------------
(Updated Aug. 27, 2013, 5:36 a.m.)
Review request for cloudstack, suresh sadhu and Prasanna Santhanam.
Changes
-------
including Suresh for review.
Repository: cloudstack-git
Description
-------
Automation Tests for HA Proxy Stickiness
Diffs
-----
test/integration/component/test_haproxy.py PRE-CREATION
Diff: https://reviews.apache.org/r/13701/diff/
Testing
-------
Thanks,
Girish Shilamkar