You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "yejiabao (Code Review)" <ge...@cloudera.org> on 2021/12/12 13:15:02 UTC

[kudu-CR] [tool] Display the "Data state" and "Last statue" in remote replica list command.

yejiabao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18092


Change subject: [tool] Display the "Data state" and "Last statue" in remote_replica list command.
......................................................................

[tool] Display the "Data state" and "Last statue" in remote_replica list command.

It's will make simple and more detail to judge tablet state by "Data state" and "Last status" in remote_replica list

Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18092/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 1
Gerrit-Owner: yejiabao <ye...@huawei.com>

[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last status" in remote replica list command.

Posted by "yejiabao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Lieber-Dembo, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18092

to look at the new patch set (#4).

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last status" in remote_replica list command.
......................................................................

[tool] KUDU-3343 Display the "Data state" and "Last status" in remote_replica list command.

It's will make simple and more detail to judge tablet state by
"Data state" and "Last status" in remote_replica list

Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
2 files changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18092/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 4
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last status" in remote replica list command.

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18092 )

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last status" in remote_replica list command.
......................................................................


Patch Set 6: Code-Review+2

Thank you for the contribution!


-- 
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 6
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 16 Dec 2021 04:14:12 +0000
Gerrit-HasComments: No

[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last statue" in remote replica list command.

Posted by "yejiabao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Lieber-Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18092

to look at the new patch set (#3).

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last statue" in remote_replica list command.
......................................................................

[tool] KUDU-3343 Display the "Data state" and "Last statue" in remote_replica list command.

It's will make simple and more detail to judge tablet state by
"Data state" and "Last status" in remote_replica list

Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18092/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 3
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last status" in remote replica list command.

Posted by "yejiabao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Lieber-Dembo, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18092

to look at the new patch set (#5).

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last status" in remote_replica list command.
......................................................................

[tool] KUDU-3343 Display the "Data state" and "Last status" in remote_replica list command.

It's will make simple and more detail to judge tablet state by
"Data state" and "Last status" in remote_replica list

Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
2 files changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18092/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 5
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last status" in remote replica list command.

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18092 )

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last status" in remote_replica list command.
......................................................................

[tool] KUDU-3343 Display the "Data state" and "Last status" in remote_replica list command.

It's will make simple and more detail to judge tablet state by
"Data state" and "Last status" in remote_replica list

Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Reviewed-on: http://gerrit.cloudera.org:8080/18092
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Bankim Bhavsar: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 7
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last status" in remote replica list command.

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18092 )

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last status" in remote_replica list command.
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 6
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Dec 2021 05:04:49 +0000
Gerrit-HasComments: No

[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last statue" in remote replica list command.

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/18092 )

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last statue" in remote_replica list command.
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18092/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18092/3//COMMIT_MSG@7
PS3, Line 7: statue
typo: status


http://gerrit.cloudera.org:8080/#/c/18092/3/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/18092/3/src/kudu/tools/kudu-tool-test.cc@3468
PS3, Line 3468:     ASSERT_STR_CONTAINS(stdout, "Data state: TABLET_DATA_TOMBSTONED");
Could you add a test case for "Last status" as well?



-- 
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 3
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Adar Lieber-Dembo <ad...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Dec 2021 15:28:08 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last statue" in remote replica list command.

Posted by "yejiabao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18092

to look at the new patch set (#2).

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last statue" in remote_replica list command.
......................................................................

[tool] KUDU-3343 Display the "Data state" and "Last statue" in remote_replica list command.

It's will make simple and more detail to judge tablet state by
"Data state" and "Last status" in remote_replica list

Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18092/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 2
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Kudu Jenkins (120)