You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kmitchener (via GitHub)" <gi...@apache.org> on 2023/02/18 14:49:40 UTC
[GitHub] [arrow-datafusion] kmitchener opened a new pull request, #5329: MINOR: nicer error messages for cli, use display format rather than debug
kmitchener opened a new pull request, #5329:
URL: https://github.com/apache/arrow-datafusion/pull/5329
# Which issue does this PR close?
Closes #.
# Rationale for this change
Better user experience
# What changes are included in this PR?
Instead of:
```
❯ select not_a_column;
SchemaError(FieldNotFound { field: Column { relation: None, name: "not_a_column" }, valid_fields: [] })
```
it's
```
❯ select not_a_column;
Schema error: No field named 'not_a_column'.
```
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
datafusion-cli uses the nicely formatted error messages already available rather than debug format for errors
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5329: MINOR: nicer error messages for cli, use display format rather than debug
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5329:
URL: https://github.com/apache/arrow-datafusion/pull/5329#issuecomment-1435710032
Benchmark runs are scheduled for baseline = 27b15fdcf3234ba050e254ec179f51e5d92e9784 and contender = 6ec254442456e33d517c021ce56a0423398ffea7. 6ec254442456e33d517c021ce56a0423398ffea7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/31ee1428c9314acaae4868d85e09ba9d...043f4a44380d46b68bf09abee3800dd9/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/79b7cee3c57e4b3399229b1d99e66e52...9a9ca1b9dd6d4521acc8b3649001eb07/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8289ab572de34715b2c01c1050edeaee...7a16bd5e398845098495e32628365ef4/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4b04396ae2444a55a13fa54992b153d2...f438e37f1386482999fd51572bee96e1/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5329: MINOR: nicer error messages for cli, use display format rather than debug
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5329:
URL: https://github.com/apache/arrow-datafusion/pull/5329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org