You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/13 15:43:18 UTC

[GitHub] [cloudstack] DK101010 opened a new pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

DK101010 opened a new pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771


   ### Description
   This PR add template flags isPublic, isFeatured, isExtractable to ui 
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   own vmware env
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-995992305


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-995860786


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 1914


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-996423023


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-998063887


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1965


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DK101010 closed pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
DK101010 closed pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-995897444


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DK101010 commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-993669706


   > @DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?
   
   Only as admin and to be honest, I have no clue what do you mean. :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-997622232


   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1951


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-993310905


   @DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-996423406


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-996084070


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-995992954


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-997610574


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DK101010 commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-996684699


   > > > @DK101010 did you test this as admin? and also as user? did you try to get weird access right issues, i mean?
   > > 
   > > 
   > > Only as admin and to be honest, I have no clue what do you mean. :D
   > 
   > ok, not sure if a user is allowed the same on template flags as the admin, hence my question. testing will have to prove the pudding
   
   Hmm ... good question. Have no Idea. These flags already existed in the old ui. How was it there?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-996741053


   <b>Trillian test result (tid-2674)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33305 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5771-t2674-kvm-centos7.zip
   Smoke tests completed. 86 look OK, 5 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 0.62 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.12 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.22 | test_primary_storage.py
   test_01_secure_vm_migration | `Error` | 170.26 | test_vm_life_cycle.py
   test_02_unsecure_vm_migration | `Error` | 274.57 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 147.32 | test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 46.94 | test_vm_life_cycle.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 32.99 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 63.78 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 44.27 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 86.54 | test_kubernetes_clusters.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 9.50 | test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 9.50 | test_snapshots.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 305.20 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-995895572


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-995943849


   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1918


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-998792204


   <b>Trillian test result (tid-2696)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 31560 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5771-t2696-kvm-centos7.zip
   Smoke tests completed. 91 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-998465342


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-998465069


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-998023145


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-997610574


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DK101010 commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-1025441811


   > There exist APIs `updateIsoPermissions` and `updateTemplatePermissions` which do pretty much the exact same thing It is also available in the UI
   > 
   > ![Screenshot from 2022-01-27 13-10-39](https://user-images.githubusercontent.com/8244774/151313240-5e18d499-07a7-4667-9b01-c904352e47a1.png)
   > 
   > ![Screenshot from 2022-01-27 13-10-48](https://user-images.githubusercontent.com/8244774/151313245-eb5f3b75-8f55-4107-9754-2cd12683fc0c.png)
   
   Oh ok, that is new for me. Thanks for the hint. I'll  close the PR.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-995776646


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-995774410






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-997610847


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-998023615


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-997610847






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5771: Make template flags isPublic, isFeatured, isExtractable editable in ui

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5771:
URL: https://github.com/apache/cloudstack/pull/5771#issuecomment-1022930385


   There exist APIs `updateIsoPermissions` and `updateTemplatePermissions` which do pretty much the exact same thing
   It is also available in the UI
   
   ![Screenshot from 2022-01-27 13-10-39](https://user-images.githubusercontent.com/8244774/151313240-5e18d499-07a7-4667-9b01-c904352e47a1.png)
   
   ![Screenshot from 2022-01-27 13-10-48](https://user-images.githubusercontent.com/8244774/151313245-eb5f3b75-8f55-4107-9754-2cd12683fc0c.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org