You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2017/02/17 03:02:29 UTC

Review Request 56777: AMBARI-20058 - 'Final' is not shown correctly in config diff tool and in older versions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56777/
-----------------------------------------------------------

Review request for Ambari, Andriy Babiichuk and Oleg Nechiporenko.


Bugs: AMBARI-20058
    https://issues.apache.org/jira/browse/AMBARI-20058


Repository: ambari


Description
-------

This issue was introduced in AMBARI-15459
Fix the condition of showing override differently.


Diffs
-----

  ambari-web/app/templates/common/configs/service_config_category.hbs fbcb828 
  ambari-web/app/views/common/configs/controls_view.js 8894ea6 

Diff: https://reviews.apache.org/r/56777/diff/


Testing
-------

Manually tested on live cluster.
All unit tests passed.
  20340 passing (23s)
  153 pending


Thanks,

Richard Zang


Re: Review Request 56777: AMBARI-20058 - 'Final' is not shown correctly in config diff tool and in older versions

Posted by Xi Wang <xw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56777/#review165963
-----------------------------------------------------------


Ship it!




Ship It!

- Xi Wang


On Feb. 16, 2017, 7:02 p.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56777/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2017, 7:02 p.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-20058
>     https://issues.apache.org/jira/browse/AMBARI-20058
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This issue was introduced in AMBARI-15459
> Fix the condition of showing override differently.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/templates/common/configs/service_config_category.hbs fbcb828 
>   ambari-web/app/views/common/configs/controls_view.js 8894ea6 
> 
> Diff: https://reviews.apache.org/r/56777/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on live cluster.
> All unit tests passed.
>   20340 passing (23s)
>   153 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>