[GitHub] [hadoop] maobaolong commented on pull request #2437: HDFS-15667. Audit log record the unexpected allowed result when delete

[GitBox <gi...@apache.org>]

maobaolong commented on pull request #2437:
URL: https://github.com/apache/hadoop/pull/2437#issuecomment-722333300


   @ferhui @Hexiaoqiao Thank you for the interesting about this PR. 
   > There is another confused point. If iip.getLastINode() == null returns true, will also print allowed=false after changes,
   
   ```java
     private static boolean deleteAllowed(final INodesInPath iip) {
       if (iip.length() < 1 || iip.getLastINode() == null) {
         if (NameNode.stateChangeLog.isDebugEnabled()) {
           NameNode.stateChangeLog.debug(
               "DIR* FSDirectory.unprotectedDelete: failed to remove "
                   + iip.getPath() + " because it does not exist");
         }
         return false;
       } else if (iip.length() == 1) { // src is the root
         NameNode.stateChangeLog.warn(
             "DIR* FSDirectory.unprotectedDelete: failed to remove " +
                 iip.getPath() + " because the root is not allowed to be deleted");
         return false;
       }
       return true;
     }
   ```
   
   Through this method, I think ` iip.getLastINode() == null` will returns false, and auditlog will record `allowed = false`. not sure to catch your point?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org