[GitHub] nifi pull request #2142: NIFI-4375: Add bufferSize to PutFTP

[ijokarumawak <gi...@git.apache.org>]

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/2142

    NIFI-4375: Add bufferSize to PutFTP

    The default buffer size is only 1kb and causes low data transfer rate.
    Added buffer size configuration so that user can specify appropriate value.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-4375

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2142
    
----
commit 2c5ebc3fe060a36434a11df5602776f999aac893
Author: Koji Kawamura <ij...@apache.org>
Date:   2017-09-11T06:19:24Z

    NIFI-4375: Add bufferSize to PutFTP
    
    The default buffer size is only 1kb and causes low data transfer rate.
    Added buffer size configuration so that user can specify appropriate value.

----


---

[GitHub] nifi pull request #2142: NIFI-4375: Add bufferSize to PutFTP

[ijokarumawak <gi...@git.apache.org>]

Github user ijokarumawak closed the pull request at:

    https://github.com/apache/nifi/pull/2142


---

[GitHub] nifi issue #2142: NIFI-4375: Add bufferSize to PutFTP

[ijokarumawak <gi...@git.apache.org>]

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/2142
  
    Closing this as it duplicates with #2141 


---

[GitHub] nifi issue #2142: NIFI-4375: Add bufferSize to PutFTP

[ijokarumawak <gi...@git.apache.org>]

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/2142
  
    Hi @glisignoli when I tested FetchFTP and GetFTP, I didn't find the same issue with PutFTP. But looked at the commons-net source code again, I found the buffer size only affect with ASCII data transfer mode. I was testing with binary mode.
    
    Thanks for the feedback. I will add the option to Get/FetchFTP processor, too. But leave ListFTP as it is, because it does not transfer data so it does not use the buffer size option.


---

[GitHub] nifi issue #2142: NIFI-4375: Add bufferSize to PutFTP

[glisignoli <gi...@git.apache.org>]

Github user glisignoli commented on the issue:

    https://github.com/apache/nifi/pull/2142
  
    You should also add it to ListFTP, FetchFTP and GetFTP


---